Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug Home components doesn't have id to navigate to #37 #38

Merged
merged 4 commits into from
Dec 3, 2019

Conversation

thuyvy3110
Copy link
Collaborator

Added id for Home components

@thuyvy3110 thuyvy3110 added the bug Something isn't working label Dec 3, 2019
@thuyvy3110 thuyvy3110 self-assigned this Dec 3, 2019
@vercel
Copy link

vercel bot commented Dec 3, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/monkeybear/phatho-porfolio-nextjs/sfx3dapm1
🌍 Preview: https://phatho-porfolio-nextjs-git-add-home-id.monkeybear.now.sh

views/components/Home.js Outdated Show resolved Hide resolved
Copy link
Owner

@DeKal DeKal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@DeKal DeKal merged commit 0eb6e35 into master Dec 3, 2019
@DeKal DeKal deleted the add-home-id branch December 3, 2019 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants