Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[135] Adding github link to Logo #139

Merged
merged 3 commits into from
Dec 30, 2019
Merged

[135] Adding github link to Logo #139

merged 3 commits into from
Dec 30, 2019

Conversation

kennySix
Copy link
Collaborator

@kennySix kennySix commented Dec 30, 2019 •
edited by DeKal
Loading

Adding github link to Logo #135

@kennySix kennySix requested a review from DeKal December 30, 2019 13:43
@vercel
Copy link

vercel bot commented Dec 30, 2019 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/monkeybear/portfolio-next-js/2zqnvhzmb
✅ Preview: https://portfolio-next-js-git-add-github-link-logo.monkeybear.now.sh

DeKal
DeKal reviewed Dec 30, 2019
View reviewed changes
Copy link
Owner

@DeKal DeKal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding :

  • Assignee
  • Label
  • Project
  • Milestone: Maintain on the right column
    Descript tion should link to issue, and describe the PR

views/components/nav/NavLogo.js Outdated Show resolved Hide resolved
views/components/nav/NavLogo.js Show resolved Hide resolved
@kennySix kennySix added the enhancement New feature or request label Dec 30, 2019
@kennySix kennySix added this to the Maintaining milestone Dec 30, 2019
@kennySix kennySix self-assigned this Dec 30, 2019
@kennySix
[#135] Adding github link to Logo
4d31608 
- On hover on the logo JD will make it change to colorAccent.
- On click to logo JD will also do the same, and redirect to this github
link.
@kennySix
[135] Adding github link to Logo
d13dfbc 
Adding github link to Logo #135
@DeKal DeKal self-requested a review December 30, 2019 15:31
DeKal
DeKal approved these changes Dec 30, 2019
View reviewed changes
Copy link
Owner

@DeKal DeKal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :+1

@DeKal DeKal merged commit 832291b into master Dec 30, 2019
@DeKal DeKal deleted the add-github-link-logo branch December 30, 2019 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeKal DeKal DeKal approved these changes

Assignees

@kennySix kennySix

Labels
enhancement New feature or request
Projects
None yet
Milestone
Maintaining
Development

Successfully merging this pull request may close these issues.
2 participants
@kennySix @DeKal