Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[135] Adding github link to Logo #139

Merged
merged 3 commits into from
Dec 30, 2019
Merged

[135] Adding github link to Logo #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4d31608
[#135] Adding github link to Logo
kennySix Dec 30, 2019
17ba58d
Fixing Snapshot
DeKal Dec 30, 2019
d13dfbc
[135] Adding github link to Logo
kennySix Dec 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions views/components/__test__/__snapshots__/Navbar.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -673,7 +673,9 @@ exports[`Navbar should render without throwing an error 1`] = `
className="col-md-2"
>
<NavLogo>
<NavLogo__Logo>
<NavLogo__Logo
href="https://github.com/DeKal/portfolio-next-js"
>
<StyledComponent
forwardedComponent={
Object {
Expand All @@ -682,7 +684,7 @@ exports[`Navbar should render without throwing an error 1`] = `
"componentStyle": ComponentStyle {
"componentId": "NavLogo__Logo-sc-1822jsu-0",
"isStatic": false,
"lastClassName": "IYNu",
"lastClassName": "hsWCem",
"rules": Array [
"display:block;position:absolute;width:",
[Function],
Expand All @@ -698,7 +700,11 @@ exports[`Navbar should render without throwing an error 1`] = `
[Function],
";border:none;@media screen and (max-width:800px){display:none;}&::after{content:'';position:absolute;bottom:-29px;left:0;z-index:250;border-top:30px solid ",
[Function],
";border-left:40px solid transparent;border-right:40px solid transparent;}",
";border-left:40px solid transparent;border-right:40px solid transparent;}&:hover{color:",
[Function],
";text-decoration:none;}&:active{color:",
[Function],
";}",
],
},
"displayName": "NavLogo__Logo",
Expand All @@ -712,9 +718,11 @@ exports[`Navbar should render without throwing an error 1`] = `
}
}
forwardedRef={null}
href="https://github.com/DeKal/portfolio-next-js"
>
<a
className="NavLogo__Logo-sc-1822jsu-0 IYNu"
className="NavLogo__Logo-sc-1822jsu-0 hsWCem"
href="https://github.com/DeKal/portfolio-next-js"
>
<NavLogo__LogoText>
<StyledComponent
Expand Down
11 changes: 10 additions & 1 deletion views/components/nav/NavLogo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import * as React from 'react'
import styled from 'styled-components/macro'

const NavLogo = () => (
<Logo>
<Logo href="https://github.com/DeKal/portfolio-next-js">
<LogoText>JD</LogoText>
</Logo>
)
Expand Down Expand Up @@ -36,6 +36,15 @@ const Logo = styled.a`
border-left: 40px solid transparent;
border-right: 40px solid transparent;
}

&:hover {
DeKal marked this conversation as resolved.
Show resolved Hide resolved
color: ${props => props.theme.colors.colorDark};
text-decoration: none;
}

&:active {
color: ${props => props.theme.colors.colorDark};
}
`

const LogoText = styled.span`
Expand Down
32 changes: 24 additions & 8 deletions views/components/nav/__test__/__snapshots__/NavContent.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,9 @@ exports[`Nav Content should render with isShowNavContent disable 1`] = `
className="col-md-2"
>
<NavLogo>
<NavLogo__Logo>
<NavLogo__Logo
href="https://github.com/DeKal/portfolio-next-js"
>
<StyledComponent
forwardedComponent={
Object {
Expand All @@ -108,7 +110,7 @@ exports[`Nav Content should render with isShowNavContent disable 1`] = `
"componentStyle": ComponentStyle {
"componentId": "NavLogo__Logo-sc-1822jsu-0",
"isStatic": false,
"lastClassName": "IYNu",
"lastClassName": "hsWCem",
"rules": Array [
"display:block;position:absolute;width:",
[Function],
Expand All @@ -124,7 +126,11 @@ exports[`Nav Content should render with isShowNavContent disable 1`] = `
[Function],
";border:none;@media screen and (max-width:800px){display:none;}&::after{content:'';position:absolute;bottom:-29px;left:0;z-index:250;border-top:30px solid ",
[Function],
";border-left:40px solid transparent;border-right:40px solid transparent;}",
";border-left:40px solid transparent;border-right:40px solid transparent;}&:hover{color:",
[Function],
";text-decoration:none;}&:active{color:",
[Function],
";}",
],
},
"displayName": "NavLogo__Logo",
Expand All @@ -138,9 +144,11 @@ exports[`Nav Content should render with isShowNavContent disable 1`] = `
}
}
forwardedRef={null}
href="https://github.com/DeKal/portfolio-next-js"
>
<a
className="NavLogo__Logo-sc-1822jsu-0 IYNu"
className="NavLogo__Logo-sc-1822jsu-0 hsWCem"
href="https://github.com/DeKal/portfolio-next-js"
>
<NavLogo__LogoText>
<StyledComponent
Expand Down Expand Up @@ -1012,7 +1020,9 @@ exports[`Nav Content should render with isShowNavContent enable 1`] = `
className="col-md-2"
>
<NavLogo>
<NavLogo__Logo>
<NavLogo__Logo
href="https://github.com/DeKal/portfolio-next-js"
>
<StyledComponent
forwardedComponent={
Object {
Expand All @@ -1021,7 +1031,7 @@ exports[`Nav Content should render with isShowNavContent enable 1`] = `
"componentStyle": ComponentStyle {
"componentId": "NavLogo__Logo-sc-1822jsu-0",
"isStatic": false,
"lastClassName": "IYNu",
"lastClassName": "hsWCem",
"rules": Array [
"display:block;position:absolute;width:",
[Function],
Expand All @@ -1037,7 +1047,11 @@ exports[`Nav Content should render with isShowNavContent enable 1`] = `
[Function],
";border:none;@media screen and (max-width:800px){display:none;}&::after{content:'';position:absolute;bottom:-29px;left:0;z-index:250;border-top:30px solid ",
[Function],
";border-left:40px solid transparent;border-right:40px solid transparent;}",
";border-left:40px solid transparent;border-right:40px solid transparent;}&:hover{color:",
[Function],
";text-decoration:none;}&:active{color:",
[Function],
";}",
],
},
"displayName": "NavLogo__Logo",
Expand All @@ -1051,9 +1065,11 @@ exports[`Nav Content should render with isShowNavContent enable 1`] = `
}
}
forwardedRef={null}
href="https://github.com/DeKal/portfolio-next-js"
>
<a
className="NavLogo__Logo-sc-1822jsu-0 IYNu"
className="NavLogo__Logo-sc-1822jsu-0 hsWCem"
href="https://github.com/DeKal/portfolio-next-js"
>
<NavLogo__LogoText>
<StyledComponent
Expand Down
4 changes: 3 additions & 1 deletion views/components/nav/__test__/__snapshots__/NavLogo.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`Nav Logo should render without throwing an error 1`] = `
<NavLogo__Logo>
<NavLogo__Logo
href="https://github.com/DeKal/portfolio-next-js"
>
<NavLogo__LogoText>
JD
</NavLogo__LogoText>
Expand Down