fix: locationtype should not be written for CrossSections or ObservationCrossSections #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion cross-sections.
…tions' of https://github.com/Deltares/HYDROLIB-core into fix/678_Locationtype_should_not_be_written_for_crosssections
|
priscavdsluis
approved these changes
Jul 9, 2024
tim-vd-aardweg
deleted the
fix/678_Locationtype_should_not_be_written_for_crosssections
branch
8 tasks
veenstrajelmer
added a commit
to Deltares/hydromt_delft3dfm
that referenced
this pull request
Sep 23, 2024
5 tasks
veenstrajelmer
added a commit
to Deltares/hydromt_delft3dfm
that referenced
this pull request
Sep 25, 2024
* updated minimal hydrolib-core version * prevented calls to deprecated hydrolib-core functions * removed locationtype from crsloc.ini files and code, was deprecated in Deltares/HYDROLIB-core#683 * resolved typo: UniFrictType to uniffricttype * prevent writing of lateral quantity in extfile * workaround for failing testcases: updated mdu keyword values, sometimes to inconvenient values * added framework of additional unit tests * updated changelog * Enable support for point cross-sections * prevent hydromt v1 alpha --------- Co-authored-by: hboisgon <[email protected]> Co-authored-by: Sebastian Hartgring <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #678