Guide documentation for cascade polder basins (#1258)

Fixes #1017 A example model for a cascade of polder basin with local PID controller was made. Wiki page updated with this guidance document.
Deltares · Apr 8, 2024 · ef7b43e · ef7b43e
1 parent 2adaec4
commit ef7b43e
Show file tree

Hide file tree

Showing 5 changed files with 614 additions and 3 deletions.
diff --git a/core/src/solve.jl b/core/src/solve.jl
@@ -154,14 +154,16 @@ function continuous_control!(
 
             factor_outlet = 1.0
 
-            # No flow of outlet if source level is lower than target level
+            # No flow out of outlet if source level is lower than reference level
             if !(src_level === nothing || dst_level === nothing)
                 Δlevel = src_level - dst_level
                 factor_outlet *= reduction_factor(Δlevel, 0.1)
             end
 
-            # No flow out outlet if source level is lower than minimum crest level
+            # No flow out of outlet if source level is lower than minimum crest level
             if src_level !== nothing
+                controlled_node_idx = findsorted(outlet.node_id, controlled_node_id)
+
                 factor_outlet *= reduction_factor(
                     src_level - outlet.min_crest_level[controlled_node_idx],
                     0.1,