Guide documentation for cascade polder basins #1258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made an example model made a first draft model modified model so the flow can behave as desired improved model with pid controller on every outlet unstable water level appears Take min crest level into account for PID controlled outlet PID control fix precipitation shortage failing one working model configuration without addAPI model with addAPI remove hour, minute and second in start/end time add image to the example page model with verticle flows model with desire parameters explain model in doc
Jingru923
force-pushed
the
1017-cascade-basins
branch
from
9f59179
to
ca1b811
Compare
gijsber
requested changes
Apr 3, 2024
There was a problem hiding this comment.
Hi @Jingru923 I've reviewed and made some textual changes. Please consider and reach out if you have any questions
SouthEndMusic
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Nice work. I did make this issue after looking at the examples notebook: #1365 (this is not just for your plots).
gijsber
approved these changes
Apr 8, 2024
| from shapely.geometry import Point | ||
|
|
||
|
|
||
| def doc_example_model(): |
There was a problem hiding this comment.
agree, what about: local_pidcontrolled_cascade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1017
A example model was made.
Wiki page with this guidance document.