Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove TimerOutputs #1741

Closed
visr opened this issue Aug 20, 2024 · 0 comments · Fixed by #1749
Closed

Remove TimerOutputs #1741

visr opened this issue Aug 20, 2024 · 0 comments · Fixed by #1749
Labels
core Issues related to the computational core in Julia dependencies Pull requests that update a dependency file tech-debt Improvements related to technical debt

Comments

@visr
Copy link
Member

visr commented Aug 20, 2024

We currently don't use it, but it is a dependency. Let's just remove it, including the config.logging.timing setting that was used for this.
@visr visr added dependencies Pull requests that update a dependency file core Issues related to the computational core in Julia tech-debt Improvements related to technical debt labels Aug 20, 2024
visr added a commit that referenced this issue Aug 22, 2024
@visr
Remove TimerOutputs
3d77099 
Fixes #1741.

Note that this is still an indirect dependency.

```
(root) pkg> why TimerOutputs
  DiffEqCallbacks → NonlinearSolve → TimerOutputs
  OrdinaryDiffEq → NonlinearSolve → TimerOutputs
  Ribasim → DiffEqCallbacks → NonlinearSolve → TimerOutputs
  Ribasim → OrdinaryDiffEq → NonlinearSolve → TimerOutputs
```
@visr visr mentioned this issue Aug 22, 2024
Merged
visr added a commit that referenced this issue Aug 26, 2024
@visr
Remove TimerOutputs (#1749)
d0494c1 
Fixes #1741.

Note that this is still an indirect dependency.

```
(root) pkg> why TimerOutputs
  Ribasim → DiffEqCallbacks → NonlinearSolve → TimerOutputs
  Ribasim → OrdinaryDiffEq → NonlinearSolve → TimerOutputs
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core Issues related to the computational core in Julia dependencies Pull requests that update a dependency file tech-debt Improvements related to technical debt
Projects
Ribasim
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove TimerOutputs Deltares/Ribasim
1 participant
@visr