Remove TimerOutputs #1749
Merged
Remove TimerOutputs #1749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1741. Note that this is still an indirect dependency. ``` (root) pkg> why TimerOutputs DiffEqCallbacks → NonlinearSolve → TimerOutputs OrdinaryDiffEq → NonlinearSolve → TimerOutputs Ribasim → DiffEqCallbacks → NonlinearSolve → TimerOutputs Ribasim → OrdinaryDiffEq → NonlinearSolve → TimerOutputs ```
|
I'm sorta sorry to see this go, but if we don't use it, why not. |
evetion
approved these changes
Aug 26, 2024
|
Yeah same, we can always bring it back. Though I feel it is hard to get good enough timing information this way. Some of the stuff we care most about is happening in dependencies. Profiling is much more informative. And we have also added |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1741.
Note that this is still an indirect dependency.