Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid re-computing the water balance error #1837

Closed
visr opened this issue Sep 23, 2024 · 0 comments · Fixed by #1896
Closed

Avoid re-computing the water balance error #1837

visr opened this issue Sep 23, 2024 · 0 comments · Fixed by #1896
Labels
core Issues related to the computational core in Julia improvement Improvements of the usability of existing functionality tech-debt Improvements related to technical debt

Comments

@visr
Copy link
Member

visr commented Sep 23, 2024 •
edited
Loading

Left to do: currently both check_water_balance_error and basin_table compute water balance errors over the saveat intervals. We should save the computations done in check_water_balance_error in SavedFlow.

Originally posted by @SouthEndMusic in #1829 (comment)
@visr visr added core Issues related to the computational core in Julia improvement Improvements of the usability of existing functionality labels Sep 23, 2024
@evetion evetion added the tech-debt Improvements related to technical debt label Oct 8, 2024
@SouthEndMusic SouthEndMusic mentioned this issue Oct 10, 2024
Merged
visr pushed a commit that referenced this issue Oct 10, 2024
@SouthEndMusic
Save all results via saving callback (follow up) (#1896)
cf73c99 
This is a follow up of #1825
(and a few unrelated experiments).

Fixes #1837.

Other changes in this PR:
- Storages from the cumulative flows are computed as a sparse
matrix-vector product
- Storage rates are computed without involving the initial storage
- Manning resistance is more stable around $\Delta h = 0$.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core Issues related to the computational core in Julia improvement Improvements of the usability of existing functionality tech-debt Improvements related to technical debt
Projects
Ribasim
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Save all results via saving callback (follow up) Deltares/Ribasim
2 participants
@visr @evetion