Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save all results via SavingCallback #1829

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Save all results via SavingCallback #1829

merged 1 commit into from
Sep 23, 2024

Conversation

SouthEndMusic
Copy link
Collaborator

Fixes #1825.

@SouthEndMusic
Copy link
Collaborator Author

Left to do: currently both check_water_balance_error and basin_table compute water balance errors over the saveat intervals. We should save the computations done in check_water_balance_error in SavedFlow.

@SouthEndMusic SouthEndMusic changed the title Stop saving results in integrator.sol Save all results via SavingCallback Sep 19, 2024
@visr visr mentioned this pull request Sep 23, 2024
Closed
@visr visr merged commit 1114838 into main Sep 23, 2024
27 checks passed
@visr visr deleted the save_all_results_via_saving_callback branch September 23, 2024 10:37
@SouthEndMusic SouthEndMusic restored the save_all_results_via_saving_callback branch October 10, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@visr visr visr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Save all results in SavingCallback
2 participants
@SouthEndMusic @visr