Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guide documentation for cascade polder basins #1258

Merged
merged 21 commits into from
Apr 8, 2024
Merged

Guide documentation for cascade polder basins #1258

Show file tree
Hide file tree
Changes from 20 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
ca1b811
create file for model scripting
Jingru923 Mar 27, 2024
f9babe4
fix plot that causes ci error
Jingru923 Mar 27, 2024
8ffad9e
all the code part in example.ipynb should be good
Jingru923 Mar 28, 2024
b03fc8f
fix the incorrect path problem
Jingru923 Mar 28, 2024
3e6bbda
first draft of documentation
Jingru923 Mar 29, 2024
a2546a0
Remove comment
Hofer-Julian Apr 2, 2024
c8ed5b4
changed a way to select column
Jingru923 Apr 2, 2024
691a505
complete merge
Jingru923 Apr 2, 2024
2c4a3df
Test windows as well on CI for docs
Hofer-Julian Apr 2, 2024
4a72f6b
Only use windows
Hofer-Julian Apr 2, 2024
915abf4
Use ubuntu again
Hofer-Julian Apr 2, 2024
fe6bc23
used copy for dataframe
Jingru923 Apr 2, 2024
eadd70c
Merge branch 'main' into 1017-cascade-basins
Jingru923 Apr 2, 2024
5308ce0
print to see what's in the dataframe
Jingru923 Apr 2, 2024
c186a9b
Merge branch 'main' into 1017-cascade-basins
Jingru923 Apr 8, 2024
9e9348e
add crs to model
Jingru923 Apr 8, 2024
c7c752b
fix the doc error
Jingru923 Apr 8, 2024
ce985c7
add csr to model in example page
Jingru923 Apr 8, 2024
47216ca
add vertical flux to basin dataframe
Jingru923 Apr 8, 2024
ec8f2d5
adopt comments on documentation
Jingru923 Apr 8, 2024
0b339cf
adopt second round of comments
Jingru923 Apr 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions core/src/solve.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,8 @@ function continuous_control!(

# No flow out outlet if source level is lower than minimum crest level
Jingru923 marked this conversation as resolved.
Show resolved Hide resolved
if src_level !== nothing
controlled_node_idx = findsorted(outlet.node_id, controlled_node_id)

factor_outlet *= reduction_factor(
src_level - outlet.min_crest_level[controlled_node_idx],
Jingru923 marked this conversation as resolved.
Show resolved Hide resolved
0.1,
Expand Down
Loading
Loading