Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python edge validation #1765

Merged
merged 32 commits into from
Sep 4, 2024
Merged

Python edge validation #1765

merged 32 commits into from
Sep 4, 2024

Conversation

Jingru923
Copy link
Contributor

Fixes #1752

@Jingru923 Jingru923 requested a review from evetion August 27, 2024 07:44
@Jingru923 Jingru923 linked an issue Aug 27, 2024 that may be closed by this pull request
Validate node types and number of edges when adding a new edge. #1752
Closed
@Jingru923 Jingru923 marked this pull request as draft August 27, 2024 07:46
@Jingru923 Jingru923 marked this pull request as ready for review August 27, 2024 09:11
@Jingru923 Jingru923 marked this pull request as draft August 27, 2024 09:14
evetion
evetion requested changes Aug 27, 2024
View reviewed changes
python/ribasim/ribasim/geometry/edge.py Outdated Show resolved Hide resolved
python/ribasim/ribasim/validation.py Outdated Show resolved Hide resolved
python/ribasim/ribasim/validation.py Outdated Show resolved Hide resolved
python/ribasim/ribasim/validation.py Outdated Show resolved Hide resolved
@Jingru923 Jingru923 marked this pull request as ready for review August 30, 2024 06:37
@Jingru923 Jingru923 requested a review from evetion August 30, 2024 07:37
@Jingru923
Copy link
Contributor Author

#1779 as a follow up issue

@visr visr changed the title Py validation Python edge validation Aug 30, 2024
evetion
evetion requested changes Sep 2, 2024
View reviewed changes
Copy link
Member

@evetion evetion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good approach, nice to see so many tests.

python/ribasim_testmodels/ribasim_testmodels/invalid.py Show resolved Hide resolved
python/ribasim/ribasim/model.py Outdated Show resolved Hide resolved
python/ribasim/ribasim/model.py Outdated Show resolved Hide resolved
python/ribasim/ribasim/validation.py Outdated Show resolved Hide resolved
python/ribasim/ribasim/validation.py Outdated Show resolved Hide resolved
python/ribasim/ribasim/validation.py Outdated Show resolved Hide resolved
python/ribasim/ribasim/geometry/edge.py Show resolved Hide resolved
python/ribasim/ribasim/model.py Outdated Show resolved Hide resolved
python/ribasim/ribasim/model.py Outdated Show resolved Hide resolved
python/ribasim/ribasim/model.py Outdated Show resolved Hide resolved
evetion
evetion requested changes Sep 2, 2024
View reviewed changes
python/ribasim/ribasim/model.py Outdated Show resolved Hide resolved
python/ribasim/ribasim/model.py Show resolved Hide resolved
python/ribasim/ribasim/model.py Outdated Show resolved Hide resolved
@Jingru923 Jingru923 merged commit 7070986 into main Sep 4, 2024
27 checks passed
@Jingru923 Jingru923 deleted the py-validation branch September 4, 2024 06:54
@visr visr mentioned this pull request Oct 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deltamarnix deltamarnix deltamarnix left review comments

@evetion evetion evetion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validate node types and number of edges when adding a new edge.
3 participants
@Jingru923 @evetion @deltamarnix