Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python edge validation #1765

Merged
merged 32 commits into from
Sep 4, 2024
Merged

Python edge validation #1765

merged 32 commits into from
Sep 4, 2024

Commits on Aug 26, 2024

  1. connectivity validation function implemented

    @Jingru923
    Jingru923 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    b1470cd View commit details
    Browse the repository at this point in the history

  2. raise error if when adding edge

    @Jingru923
    Jingru923 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    a3ec21f View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. fix build error

    @Jingru923
    Jingru923 committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    d71736a View commit details
    Browse the repository at this point in the history

  2. fix pytest error

    @Jingru923
    Jingru923 committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    8618950 View commit details
    Browse the repository at this point in the history

  3. fix pytest error 2

    @Jingru923
    Jingru923 committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    fed1102 View commit details
    Browse the repository at this point in the history

  4. fix build error 2

    @Jingru923
    Jingru923 committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    e408fd7 View commit details
    Browse the repository at this point in the history

  5. fix build error 3

    @Jingru923
    Jingru923 committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    979b993 View commit details
    Browse the repository at this point in the history

  6. add unit test for validation

    @Jingru923
    Jingru923 committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    d4c97e6 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. adding neighbor limit

    @Jingru923
    Jingru923 committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    a0e3214 View commit details
    Browse the repository at this point in the history

  2. check minimum for flow edge

    @Jingru923
    Jingru923 committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    df50143 View commit details
    Browse the repository at this point in the history

  3. pass pytest

    @Jingru923
    Jingru923 committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    f326e39 View commit details
    Browse the repository at this point in the history

  4. added unit test for flow edge neighbor bound

    @Jingru923
    Jingru923 committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    26bc35d View commit details
    Browse the repository at this point in the history

  5. add another tests for outneighbor

    @Jingru923
    Jingru923 committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    aa0a173 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. unit tests for minimum in-/outneighbor

    @Jingru923
    Jingru923 committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    b330e95 View commit details
    Browse the repository at this point in the history

  2. wrote unit test for maximum control edge neighbor

    @Jingru923
    Jingru923 committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    1d26183 View commit details
    Browse the repository at this point in the history

  3. delete useless print line

    @Jingru923
    Jingru923 committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    103958d View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into py-validation

    @Jingru923
    Jingru923 committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    a997501 View commit details
    Browse the repository at this point in the history

  5. add keyword of validation in Model class

    @Jingru923
    Jingru923 committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    66d5a1e View commit details
    Browse the repository at this point in the history

  6. fix mypy error

    @Jingru923
    Jingru923 committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    7c52bd8 View commit details
    Browse the repository at this point in the history

  7. fix py311 py310 test 1

    @Jingru923
    Jingru923 committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    7688be2 View commit details
    Browse the repository at this point in the history

  8. fix julia unit test

    @Jingru923
    Jingru923 committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    59c5233 View commit details
    Browse the repository at this point in the history

  9. move validation unit tests to a different file

    @Jingru923
    Jingru923 committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    58911ea View commit details
    Browse the repository at this point in the history

  10. adding unit test for minimum control edge amount

    @Jingru923
    Jingru923 committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    6c9622f View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. move validation of edge.add to a separate function

    @Jingru923
    Jingru923 committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    be13e64 View commit details
    Browse the repository at this point in the history

  2. suggest possible downstream notetype in error message

    @Jingru923
    Jingru923 committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    4177665 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2024

  1. address all comments

    @Jingru923
    Jingru923 committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    894d8c7 View commit details
    Browse the repository at this point in the history

  2. refactor and split check_neighbor_amount function

    @Jingru923
    Jingru923 committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    d9d5394 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into py-validation

    @Jingru923
    Jingru923 committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    fe203cf View commit details
    Browse the repository at this point in the history

  4. fix outlets after merge

    @Jingru923
    Jingru923 committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    088b869 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. 2nd round of refactoring

    @Jingru923
    Jingru923 committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    bae5d6f View commit details
    Browse the repository at this point in the history

  2. move validation function up a bit

    @Jingru923
    Jingru923 committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    450d81c View commit details
    Browse the repository at this point in the history

  3. 3rd round of refactor

    @Jingru923
    Jingru923 committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    2761043 View commit details
    Browse the repository at this point in the history