Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update FindFirstFunctions #1798

Merged
merged 2 commits into from
Sep 4, 2024
Merged

update FindFirstFunctions #1798

merged 2 commits into from
Sep 4, 2024

Conversation

SouthEndMusic
Copy link
Collaborator

The new version contains my upstream fix SciML/FindFirstFunctions.jl#26.

Is this the way to go, or should we keep it as a direct dependency to be able to set the compat?

Copy link
Member

@visr visr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. It's very unlikely that we will suddenly get an older v1 version when updating packages.

@SouthEndMusic SouthEndMusic merged commit da13334 into main Sep 4, 2024
27 checks passed
@SouthEndMusic SouthEndMusic deleted the update-FindFirstFunctions branch September 4, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants