Catch inexact rounding error #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SouthEndMusic
added a commit
to Deltares/Ribasim
that referenced
this pull request
Sep 4, 2024
These changes are needed for running the `De Dommel` model for Ribasim NL and were requested by Neeltje. The main change is that `ManningResistance` has low storage factors now, which is important to have if the connected basins have different bottom levels. I made an unified approach for low storage factors of `LinearResistance` and `ManningResistance`, where the former already had low storage factors for both connected basins. That however leads to weird behavior where water cannot flow into an empty basin via the resistance node, so now I made it so that the reduction factor is based on the storage of the upstream basin as defined by the flow direction. This feels a bit discontinuous but I think it's fine. I also fixed an upstream issue in `FindFirstFunctions`, for now the manifest points at the branch with the fix: SciML/FindFirstFunctions.jl#26.
SouthEndMusic
added a commit
to Deltares/Ribasim
that referenced
this pull request
Sep 4, 2024
The new version contains my upstream fix SciML/FindFirstFunctions.jl#26.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25