Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the images in the quick start guide documentation #1805

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Fix the images in the quick start guide documentation #1805

merged 2 commits into from
Sep 6, 2024

Conversation

Jingru923
Copy link
Contributor

Fixes #1800

I updated the policy in MinIO and now we have a public folder especially for storing images for documentation called doc-image. All the image in quick start guide are in the doc-image/quickstart.

@Jingru923 Jingru923 requested a review from visr September 6, 2024 09:50
@Jingru923 Jingru923 linked an issue Sep 6, 2024 that may be closed by this pull request
Storing image in our documentation in MinIO #1800
Closed
visr
visr approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@visr visr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, let's try this. If you don't mind, I'd replace the spaces in the filenames with dashes, then we don't need to encode them %20, that is more readable also.

@visr visr merged commit 329a1e7 into main Sep 6, 2024
24 of 27 checks passed
@visr visr deleted the image-in-minio branch September 6, 2024 10:38
This was referenced Sep 26, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@visr visr visr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Storing image in our documentation in MinIO
2 participants
@Jingru923 @visr