-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New tool JSON>Table/CSV/Excel #1003
Conversation
A thought on the UI: This is currently NOT achievable with the API we have, but how about: instead of having a Setting where we chose between CSV, TSV, FSV, we have a drop down button in the command bar to copy as CSV, TSV, FSV, along with "Save as..." (which would suggest CSV...etc). Something similar to what there is in the text box when the UI gets too small: Except that user could choose between CSV, TSV, FSV. What do you think @sakana280 ? Let's no block your PR on this idea, since there's no API to achieve this. It's just something for me to think about for a future PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @sakana280, it looks GREAT in overall :D Thank you so much for this!
Just a few suggestions and we should be good to go.
src/app/dev/DevToys.Tools/Tools/Converters/JsonTable/JsonTableConverterGuiTool.cs
Outdated
Show resolved
Hide resolved
src/app/dev/DevToys.Tools/Tools/Converters/JsonTable/JsonTableConverterGuiTool.cs
Outdated
Show resolved
Hide resolved
src/app/dev/DevToys.Tools/Tools/Converters/JsonTable/JsonTableConverterGuiTool.cs
Show resolved
Hide resolved
src/app/dev/DevToys.Tools/Tools/Converters/JsonTable/JsonTableConverterGuiTool.cs
Show resolved
Hide resolved
src/app/dev/DevToys.Tools/Tools/Converters/JsonTable/JsonTableConverterCommandLineTool.cs
Outdated
Show resolved
Hide resolved
src/app/dev/DevToys.Tools/Tools/Converters/JsonTable/JsonTableConverter.resx
Outdated
Show resolved
Hide resolved
src/app/dev/DevToys.Tools/Tools/Converters/JsonTable/JsonTableConverter.resx
Outdated
Show resolved
Hide resolved
src/app/dev/DevToys.Tools/Tools/Converters/JsonTable/JsonTableConverter.resx
Outdated
Show resolved
Hide resolved
src/app/dev/DevToys.Tools/Tools/Converters/JsonTable/JsonTableConverter.resx
Outdated
Show resolved
Hide resolved
src/app/dev/DevToys.Tools/Tools/Converters/JsonTable/JsonTableConverter.resx
Outdated
Show resolved
Hide resolved
Improved naming for CLI tool and UI elements. Don't overflow large JSON lists.
Cheers heaps for the review. I've addressed all the comments (I think?) except with a query about retaining "Excel" in the search terms only. |
Hi @sakana280 , Thanks for addressing my feedback so quickly. It remains 1 tiny fix to do and we should be all good to go 😍 Cheers ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello,
It looks great now, thank you so much for your contribution! 😁
Many thanks @veler for helping me navigate the codebase and your speedy review of this PR :) |
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Requests for JSON<>CSV conversion in
#200
#671
#708
What is the new behavior?
Other information
Possible future ideas:
Quality check
Before creating this PR:
I couldn't build Release, but also couldn't build Release for the base dev/2.0 branch. Error message is:
Could not write to output file 'C:\Programming\DevToys.v2\obj\AnyCPU\DevToys.Business\Release\net7.0\generated\CommunityToolkit.Mvvm.SourceGenerators\CommunityToolkit.Mvvm.SourceGenerators.RelayCommandGenerator\DevToys.Business.ViewModels.ToolPageViewModel.ToggleSelectedMenuItemFavorite.g.cs' -- 'Could not find a part of the path 'C:\Programming\DevToys.v2\obj\AnyCPU\DevToys.Business\Release\net7.0\generated\CommunityToolkit.Mvvm.SourceGenerators\CommunityToolkit.Mvvm.SourceGenerators.RelayCommandGenerator\DevToys.Business.ViewModels.ToolPageViewModel.ToggleSelectedMenuItemFavorite.g.cs'.' DevToys.Business (net7.0) C:\Programming\DevToys.v2\src\app\dev\DevToys.Business\CSC