Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added IUIDropDownButton and improve Json > Table UI #1006

Merged
merged 2 commits into from
Dec 22, 2023

Conversation

veler
Copy link
Collaborator

@veler veler commented Dec 20, 2023

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • New feature or enhancement
  • UI change (please include screenshot!)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

We just added a JSON > Table converter tool to DevToys 2.0. See #1003.
The UI could be improved using a Drop Down Button, which isn't available in our API yet.

Issue Number: #1005

What is the new behavior?

  1. Added IUIDropDownButton.
  2. Updated JSON > Table tool with a drop down button on top of the Data Grid that allows to copy or save the grid as CSV.
  3. Did some refactoring
  4. Added StepChanged event to IUINumberInput (seems like it got forgotten)

Other information

Before:
image

After:
image

Quality check

Before creating this PR:

  • Did you follow the code style guideline as described in CONTRIBUTING.md
  • Did you build the app and test your changes?
  • Did you check for accessibility? On Windows, you can use Accessibility Insights for this.
  • Did you verify that the change work in Release build configuration
  • Did you verify that all unit tests pass
  • If necessary and if possible, did you verify your changes on:
    • Windows
    • macOS (DevToys 2.0)
    • Linux (DevToys 2.0)

@veler veler added the devtoys-v2.0 DevToys v2.0 label Dec 20, 2023
@veler veler requested a review from btiteux December 20, 2023 01:40
@veler
Copy link
Collaborator Author

veler commented Dec 20, 2023

Hi @sakana280, here is my suggested change to JSON > Table using Drop Down Button. What do you think? 😊

@veler veler mentioned this pull request Dec 20, 2023
@veler veler linked an issue Dec 20, 2023 that may be closed by this pull request
@sakana280
Copy link
Contributor

Nice work! The target formats feel more natural as options in the dropdowns than as a tool-wide setting.

@veler veler merged commit da2cfe5 into dev/2.0 Dec 22, 2023
@veler veler deleted the dev/2.0-json-table-improvement branch December 22, 2023 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devtoys-v2.0 DevToys v2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon & UI improvement to JSON > Table
2 participants