This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
Replace normalize selector paradigm with hopefully cleaner objectify selector paradigm #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added FAQ.md * FAQ.md - Additional spacing * Added Anchor Links & Formatting * Formatting * Update FAQ.md * Create FAQ.md * Updated FAQ
…iaVir#265) * c.order_poll_time was not honored in trade.js/engine.js, therefore leading to API rate limit issues e.g. with Kraken * Kraken API: Further fix maker order & silence more common errors
* Bitfinex hotfix * update package-lock.json
tested and working maker and taker when executing zenbot buy or sell. No more API down!
retry() may be necessary for getTrades and getQuote. For other I don't see the point. It crashes buy and sell. Have experienced it.
Per warning:
mongodb_1 | 2017-12-11T14:05:29.348+0000 I CONTROL [initandlisten] ** WARNING: This server is bound to localhost.
mongodb_1 | 2017-12-11T14:05:29.348+0000 I CONTROL [initandlisten] ** Remote systems will be unable to connect to this server.
mongodb_1 | 2017-12-11T14:05:29.348+0000 I CONTROL [initandlisten] ** Start the server with --bind_ip <address> to specify which IP
mongodb_1 | 2017-12-11T14:05:29.348+0000 I CONTROL [initandlisten] ** addresses it should serve responses from, or with --bind_ip_all to
mongodb_1 | 2017-12-11T14:05:29.348+0000 I CONTROL [initandlisten] ** bind to all interfaces. If this behavior is desired, start the
mongodb_1 | 2017-12-11T14:05:29.348+0000 I CONTROL [initandlisten] ** server with --bind_ip 127.0.0.1 to disable this warning.
Resolves issue:
server_1 | warning: mongodb not accessible. some features (such as backfilling/simulation) may be disabled.
server_1 | /app/node_modules/sosa_mongo/mongo_backend.js:6
server_1 | if (!backend_options.db) throw new Error('must pass a node-mongodb-native db with backend_options.db');
server_1 | ^
server_1 |
server_1 | Error: must pass a node-mongodb-native db with backend_options.db
server_1 | at module.exports (/app/node_modules/sosa_mongo/mongo_backend.js:6:34)
server_1 | at /app/node_modules/sosa/index.js:7:17
server_1 | at createCollection (/app/db/createCollection.js:5:7)
server_1 | at Object.container (/app/db/sessions.js:2:36)
server_1 | at Object.getValue (/app/node_modules/codemap/index.js:298:22)
server_1 | at /app/node_modules/codemap/index.js:238:23
server_1 | at Array.forEach (<anonymous>)
server_1 | at Object.get (/app/node_modules/codemap/index.js:237:13)
server_1 | at get (/app/node_modules/codemap/index.js:60:22)
server_1 | at Command.<anonymous> (/app/commands/trade.js:319:24)
server_1 | at Command.listener (/app/node_modules/commander/index.js:315:8)
server_1 | at Command.emit (events.js:159:13)
server_1 | at Command.parseArgs (/app/node_modules/commander/index.js:653:12)
server_1 | at Command.parse (/app/node_modules/commander/index.js:475:21)
server_1 | at /app/zenbot.js:39:11
server_1 | at /app/boot.js:28:7
server_1 | at f (/app/node_modules/once/once.js:25:25)
server_1 | at Glob.<anonymous> (/app/node_modules/glob/glob.js:151:7)
server_1 | at Glob.emit (events.js:159:13)
server_1 | at Glob._finish (/app/node_modules/glob/glob.js:197:8)
server_1 | at done (/app/node_modules/glob/glob.js:182:14)
server_1 | at Glob._processGlobStar2 (/app/node_modules/glob/glob.js:637:12)
zenbot_server_1 exited with code 1
* Fix automatic products generation. Fix commi 757 that overwrote minimun increment for kraken products * Catching more recoverable connection errors in Kraken * Fix indenting -Issue DeviaVir#800 : Fix QueryOrders price * Fix indenting * Catching more recoverable connection errors in Kraken * Catching more recoverable connection errors in Kraken * Catching generic 522 error * Catching more recoverable connection errors in Kraken * Catching more recoverable connection errors in Kraken * Fix new line in debug log
* Fix automatic products generation. Fix commi 757 that overwrote minimun increment for kraken products * Catching more recoverable connection errors in Kraken * Fix indenting -Issue DeviaVir#800 : Fix QueryOrders price * Fix indenting * Catching more recoverable connection errors in Kraken * Catching more recoverable connection errors in Kraken * Catching generic 522 error * Fix Kraken products minimun order size (volume) for each produtcts, according to https://support.kraken.com/hc/en-us/articles/205893708-What-is-the-minimum-order-size-
* Use actual price if possible. In market order the actual price (api_order.price) should be very different from trade price * Fix comment Fix comment
* Add simple vwap indicator. * Add simple vwap indicator * Add crossover_vwap strategy, based on tests with XRP-EUR on kraken. * Add crossover_vwap strategy, based on tests with XRP-EUR on kraken. Tweaked reporting within strat & defaults.
…e all values in the export. Allows for further enhancement of the graphcs. (DeviaVir#854)
…#858) * Add crossover_vwap strategy to readme. * Clean up crossover_vwap strategy source. * Clean up phenotype create indent for int0 * Add crossover_vwap strategy to genetic backtester. Add RangeFactor function to support testing ranges at a factor of 10,100, 1000 etc. * Add example sim results demonstrating effects of vwap_max parameter. * Add CSS for example sim results from crossover_vwap strategy. * Add index, for GH Pages support.
* Update strategy.js * Update strategy.js * Update strategy.js * Update strategy.js
* stddev calculate on period less api calls * Update strategy.js * Update strategy.js
* enable discord customizations Signed-off-by: Evan Hazlett <[email protected]> * Update discord.js
…tId, asset, currency, or normalized selector. Now making use of an object with fields for those values, rather than calculating them in several places. Also, where calls were made to get a normalized/objectified selector but nothing was done with the results, that code was removed. For example see, buy.js, and sell.js.
This was referenced Mar 24, 2020
This was referenced Jan 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Selector is now thought of as an object, rather than a string.
Abstracted out the common code which determined an exchangeId, productId, asset, currency, or normalized selector. Now making use of an object with fields for those values, rather than calculating them in several places.
Also, where calls were made to get a normalized/objectified selector but nothing was done with the results, that code was removed. For example see, buy.js, and sell.js.