Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bundling/path errors, sidecar support, asset hotreload fixes #2779

Draft
wants to merge 166 commits into
base: main
Choose a base branch
from

Conversation

jkelleyrtp
Copy link
Member

@jkelleyrtp jkelleyrtp commented Aug 3, 2024

Attempt fixes for:

Misc cleanup:

  • fix all cache thrashing
  • get mobile + fullstack working
  • change fullstack to be a binary yes/no thing
  • helpful warnings when running fullstack w/o server functions
  • refactor CLI staging to include bundles (and thus, bundled hotreloading)
  • lay groundwork for Ability To Build/Bundle Multiple Platforms At Once #2754
  • adds run command (like serve without the TUI)

Currently cutting out:

  • parse env!() as std::env::var or meta tags in html
  • drop dep count on cli-config
  • dioxus-hotreload should be dioxus-devtools

Pending to be cut out:

  • change "hotreload" crate to "devtools"
  • adds http-server command
  • adds doctor command for tooling
  • rename "hotreload" feature to "devtools"

Cut out of this PR (and merged):

Cut out and pending merge:

  • eval is behind document and not a "free" function
  • move Title/Stylesheet/Link behind document module (ie document::Title {}
  • completely change launch function to not warn us with deprecation lints
  • router uses document navigation abstraction
  • remove channel Evalutor (todo: move this to sdk? separate crate?)
  • new dioxus-document crate (pulled out of html)
  • remove websys from html (via newtypes in web)
  • remove js gen from dioxus-html

Punted:

We have many "dioxus rebuilds too frequently errors" and mostly it's due to cache thrashing because of env!() in build scripts and rustflags being incompatible.

@jkelleyrtp jkelleyrtp changed the title Fix bundling/path errors Fix bundling/path errors, sidecar support, asset hotreload fixes Aug 3, 2024
@jkelleyrtp jkelleyrtp marked this pull request as draft August 3, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant