Chore: hoist example projects for discoverability #2959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ealmloff
reviewed
Sep 13, 2024
ealmloff
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
I like these examples being at the top level, but the /examples vs /example-projects distinction doesn't seem that useful. Many of these examples are simple unstyled examples that happen to use a full project to make the cargo.toml easier to copy. It might be better to just keep the example-projects we moved over from the original repo in the folder and fullstack-hackernews and move the rest of the full crate examples into the examples folder
52 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hoist all of our example projects into a top-level "example-projects" folder, similar to NextJS and Leptos.
This should make discoverability easier.
Also removes the OIDC example since it wasn't working and wasn't properly updated for 0.5.
Cut out of #2779 to make that PR smaller
Closes DioxusLabs/example-projects#45