Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Japanese translation improvements from Crowdin made by: #1574

Merged
merged 1 commit into from
Sep 24, 2019

Conversation

@magul magul requested a review from a team September 16, 2019 09:23
@magul
Copy link
Member Author

magul commented Sep 24, 2019

There's no activity from @DjangoGirls/ja-pr for more than a week. Merging without explicit approval.

@magul magul merged commit 9c18ee3 into DjangoGirls:master Sep 24, 2019
@magul magul deleted the crowdin-translation-ja branch September 24, 2019 21:02
@ftnext
Copy link
Contributor

ftnext commented Oct 2, 2019

@magul
Thank you for merging translation improvement.

I am engaged in review of Japanese translation in Crowdin, and 83% was reviewed on 1st October.

Could you merge translation improvement on 3rd October or 4th?
On 5th October, a meeting for workshop coaches will be held in Tokyo, and I want coaches to check the newest translation in the meeting.

@magul
Copy link
Member Author

magul commented Oct 2, 2019

@ftnext sure thing, Give me just info when and I should prepare a pull request in less than an hour.

@ftnext
Copy link
Contributor

ftnext commented Oct 2, 2019

@magul Thanks!
I want you to create a pull request and merge it between 13:00 4th Oct. (JST) and 24:00 4th Oct. (JST) when you like.
It seems to be between 6:00 and 17:00 in Poland.

@magul
Copy link
Member Author

magul commented Oct 2, 2019

I should be available from 9 am CEST, so I should prepare pull request in few hours.

@ftnext
Copy link
Contributor

ftnext commented Nov 3, 2019

@magul
Hi. I completed review of Japanese translation.
It is very helpful for you to create Pull Request (see Issue #1615 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants