Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Japanese translation improvements from Crowdin made by: #1616

Merged
merged 1 commit into from
Nov 4, 2019

Conversation

magul
Copy link
Member

@magul magul commented Nov 4, 2019

Copy link
Contributor

@ftnext ftnext left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@magul Thanks!
Looks good to me.

@magul magul merged commit 0b5c4c0 into DjangoGirls:master Nov 4, 2019
@magul magul deleted the crowdin-translation-ja branch November 4, 2019 15:17
@ftnext
Copy link
Contributor

ftnext commented Nov 9, 2019

@magul Thank you for updating master branch!😃
I have a question: when the latest translation is deployed?

I was checking https://tutorial.djangogirls.org/ja/ for a few days,
but it seems the older version (not the latest) 🤔

A workshop in Tokyo will be held in next weekend (16th Nov.),
so I am glad if the latest Japanese translation is deployed by the Tokyo workshop.

@magul
Copy link
Member Author

magul commented Nov 9, 2019

@ftnext, unfortunately, there's an internal problem with triggering GitBook content refresh from GitHub. We have in-depth conversation about that in #1613.

I'm in the middle of gaining access to GitBook (ping @GirlGeekUpNorth) but will also try to figure out if I'm able to trigger that deployment without using GitHub altogether.

Sorry for the inconvenience!

@magul
Copy link
Member Author

magul commented Nov 9, 2019

No lucky there

magul@bohr tutorial (master=) $ git push gitbook master
Username for 'https://git.gitbook.com': magul
Password for 'https://[email protected]': 
Enumerating objects: 222, done.
Counting objects: 100% (167/167), done.
Delta compression using up to 4 threads
Compressing objects: 100% (85/85), done.
Writing objects: 100% (106/106), 83.77 KiB | 5.24 MiB/s, done.
Total 106 (delta 41), reused 40 (delta 11)
remote: error: failed to lock refs/heads/master
To https://git.gitbook.com/djangogirls/djangogirls-tutorial.git
 ! [remote rejected]     master -> master (failed to lock)
error: failed to push some refs to 'https://git.gitbook.com/djangogirls/djangogirls-tutorial.git'

@magul
Copy link
Member Author

magul commented Nov 9, 2019

It occurs that even if CLI states update was rejected it occurs on a website. Can you confirm, that there's a most up-to-date version of Japanese tutorial?

@ftnext
Copy link
Contributor

ftnext commented Nov 10, 2019

Can you confirm, that there's a most up-to-date version of Japanese tutorial?

I think that Japanese translation in this repo is the most up-to-date,
and Japanese translation in https://tutorial.djangogirls.org/ja/ is older than this repo.
It seems that there are the above 2 versions to me.

@magul
Copy link
Member Author

magul commented Nov 10, 2019

@ftnext after I asked you to check I did also some checks by myself and I can confirm that this commit

0b5c4c0 is available on GitBook right now (at least the anchors for subchapters of Installation chapter are these that were introduced in this commit).

On what basis you're claiming that there's different commit?

@ftnext
Copy link
Contributor

ftnext commented Nov 10, 2019

@magul The issue seems to have been resolved in the last half day.
I checked 0b5c4c0 is available on GitBook at the following points:

  • the table of contents in left side
    • half day before: Django URLs (at 9c18ee3 )
    • -> now: Django URL
  • What's next
    • half day before: Dajngo (there was a typo at 9c18ee3 )
    • -> now: Django (the typo is fixed by available translation of 0b5c4c0 )

On what basis you're claiming that there's different commit?

The basis is as above.

My question is resolved now and I am relieved that the latest Japanese translation is available.
It is strange that Japanese translation is updated after some days from merge.
Thank you for your effort!

@magul
Copy link
Member Author

magul commented Nov 10, 2019

Unfortunately, there are issues with GitHub -> Legacy Gitbook integration. I manually refreshed the content of the tutorial yesterday. More info about how I achieved that you can find in #1613 but info about that should be also in few comments above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants