{{ROOT_URL}} (for registration) not getting replaced during build

[NullVoxPopuli]

all I have is this (in my ember-cli-config):

    'ember-service-worker': {  },

but in the output, I'm getting:

(function(){"use strict"
function n(n){e.push(n)}var e=[],r=[]
"serviceWorker"in navigator&&navigator.serviceWorker.register("{{ROOT_URL}}sw.js",{scope:"{{ROOT_URL}}"}).

[NullVoxPopuli]

this is what I'm doing to avoid the issue in the mean time.

sed -i -e 's/{{ROOT_URL}}/\//g' dist/index.html

with the inline registration option.

[NullVoxPopuli]

this is reproducible running on my host machine:

here is my project if you guys ever decide to look https://gitlab.com/NullVoxPopuli/emberclear/tree/master/packages/frontend

running with

ENABLE_SW=true yarn start

;p

[bracke]

I'm also getting this.

[NullVoxPopuli]

Started some work on this here: #130

[stukalin]

Tried to upgrade the Ember from v3.4 to 3.5 today and received the same issue... Looking forward to see a fix

[NullVoxPopuli]

@stukalin how good are you at debugging rollup builds? #130 :D

[balinterdi]

I have the same issue but in my case even replacing {{ROOT_URL}} with /' doesn't fix it. The sw.js` request still has the encoded form prepended to it:

I also just bumped into this when upgrading to 3.5.

@NullVoxPopuli Unfortunately, I'm very untalented when it comes to debugging rollup builds :(

[erkie]

Found it:

https://github.com/DockYard/ember-service-worker/blob/master/lib/service-worker-builder.js#L88

Needs to be changed to:

-      include: ['**/ember-service-worker/**/*.js'],
+      include: ['/**/ember-service-worker/**/*.js'],

Note the leading slash. Then it works!

Need to run out for a couple of hours, but can make a PR with some tests later today or tomorrow. If nobody beats me to it :D

[NullVoxPopuli]

@erkie thanks! in #132, I've made your change and it fixed my issue in emberclear.io .

[eshtadc]

Fixed in #132