added the regular expression for windows paths #143
Conversation
|
@eshtadc would you mind to have a look at this one? We'd want the fix to be released (otherwise I end up having my dev repo npm-linked for ever) |
| // same as above but for windows paths like D:\my-ember\ember-service-worker\whatever\sw.js; | ||
| // the original one doesn't work when the source code and the %TMP% folder, which ember started to use after v3.5, are located on different logical drives | ||
| // which is quite common in Windows. | ||
| /^[a-z]:\/(?:[^\/:*?"<>|\r\n]+\/)*ember-service-worker\/(?:[^\/:*?"<>|\r\n]+\/)*[^\/:*?"<>|\r\n]*\.js$/i |
There was a problem hiding this comment.
It appears that you are checking for "/" in the regex rather than "" in the comment. Which one is the intended? I seem to recall windows paths being more like your example but it's been a while....
There was a problem hiding this comment.
Yes, it is true. Windows paths do have \ as path separators, but somewhere in the code all the paths are "normalized" to use only /s. I may fix the comment though. What would you say?
There was a problem hiding this comment.
Sorry for the silence... holidays and all. I'm trying to find where that happens but I'm coming up short. I would just make the comment as explicit as it needs to be so that the next person looking at this understands why the regex is the way it is. Maybe same as above but for windows paths like D:\my-ember\ember-service-worker\whatever\sw.js; which are updated before this step to D:/my-ember/ember-service/worker/whatever/sw.js
|
Thanks @stukalin! Release coming soon. |
Fixes #142.
Addresses #125.
The fix adds another
includefilter which contains a Windows path regular expression. I took the expression from here, replaced\with/and addedember-service-workerand.jslike in the glob pattern.In theory this should not interfere with the glob expression which will work like it did before and should only cover the case described in #142.