Remove unnecessary retroactive attribute
#869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was not needed because the type and the extension are declared within the same module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
@retroactiveattribute was necessary in Xcode 16, so it was applied using a macro branching process. However, the proposal SE-0364 describes a method that does not require macro branching and switches to that fully qualified method.ColorAssetandFontConvertibletypes did not need the@retroactiveattribute, so the attribute and macros were removed.Thememodule, and the extensions were declared in the sameThememodule.@retroactiveattribute is necessary when changes are made from external modules, so it was not meaningful in this context.Links
Screenshot (Optional if screenshot test is present or unrelated to UI)
Movie (Optional)