Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary retroactive attribute #869

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Remove unnecessary retroactive attribute #869

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae18abf
Use fully-qualified type for Selectable conformance
yimajo Aug 29, 2024
2a30346
Remove unnecessary (at)retroactive attribute
yimajo Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions app-ios/Sources/FavoriteFeature/FavoriteView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,13 +83,7 @@ public struct FavoriteView: View {
}
}

#if hasFeature(RetroactiveAttribute)
extension DroidKaigi2024Day: @retroactive Selectable {}
#else
extension DroidKaigi2024Day: Selectable {}
#endif

extension DroidKaigi2024Day {
extension DroidKaigi2024Day: Model.Selectable {
public var id: Self {
self
}
Expand Down
24 changes: 3 additions & 21 deletions app-ios/Sources/SearchFeature/SearchView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,13 +183,7 @@ public struct SearchView: View {
}
}

#if hasFeature(RetroactiveAttribute)
extension DroidKaigi2024Day: @retroactive Selectable {}
#else
extension DroidKaigi2024Day: Selectable {}
#endif

extension DroidKaigi2024Day {
extension DroidKaigi2024Day: Model.Selectable {
public var id: Self {
self
}
Expand All @@ -212,13 +206,7 @@ extension DroidKaigi2024Day {
}
}

#if hasFeature(RetroactiveAttribute)
extension TimetableSessionType: @retroactive Selectable {}
#else
extension TimetableSessionType: Selectable {}
#endif

extension TimetableSessionType {
extension TimetableSessionType: Model.Selectable {
public var id: Self {
self
}
Expand All @@ -228,13 +216,7 @@ extension TimetableSessionType {
}
}

#if hasFeature(RetroactiveAttribute)
extension Lang: @retroactive Selectable {}
#else
extension Lang: Selectable {}
#endif

extension Lang {
extension Lang: Model.Selectable {
public var id: Self {
self
}
Expand Down
4 changes: 0 additions & 4 deletions app-ios/Sources/Theme/ColorAsset+Sendable.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1 @@
#if hasFeature(RetroactiveAttribute)
extension ColorAsset: @retroactive @unchecked Sendable {}
#else
extension ColorAsset: @unchecked Sendable {}
#endif
4 changes: 0 additions & 4 deletions app-ios/Sources/Theme/FontConvertible+Sendable.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1 @@
#if hasFeature(RetroactiveAttribute)
extension FontConvertible: @retroactive @unchecked Sendable {}
#else
extension FontConvertible: @unchecked Sendable {}
#endif
Loading