773: Auto download parameters on CONNECTED #955
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en paramFragment is opened
|
@arthurbenemann This one is almost ready to merge. Just one small issue that I can't seem to fix: Going to settings>parameters will automatically restart a parameters download. Why??? Also, I get warned of a memory leak when I leave the parameters page. No crash, just a warning. And I think that was there before. |
| @@ -60,6 +59,7 @@ public void receiveData(MAVLinkMessage msg) { | |||
| case msg_heartbeat.MAVLINK_MSG_ID_HEARTBEAT: | |||
| msg_heartbeat msg_heart = (msg_heartbeat) msg; | |||
| drone.type.setType(msg_heart.type); | |||
| drone.state.setIsFlying(((msg_heartbeat) msg).system_status==MAV_STATE.MAV_STATE_ACTIVE); | |||
There was a problem hiding this comment.
Does this work well? Have you checked?
There was a problem hiding this comment.
Yes, it works. Check out line 25 of this to understand why:
There was a problem hiding this comment.
Kudos for Kevin!
ArduPilot/ardupilot@240a9cc
ArduPilot/ardupilot@996eda0
|
This issue was fixed with a different pull request, #976 . Some of the changes here are good changes. I'll make a new PR for those. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in Progress. TODO: