Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Param download on start #976

Merged
merged 3 commits into from
Aug 15, 2014
Merged

Param download on start #976

merged 3 commits into from
Aug 15, 2014

Conversation

arthurbenemann
Copy link
Member

Closes #773

arthurbenemann added a commit that referenced this pull request Aug 15, 2014
@arthurbenemann arthurbenemann merged commit d0774c2 into master Aug 15, 2014
@arthurbenemann arthurbenemann deleted the param_download_on_start branch August 15, 2014 00:30
@squilter
Copy link
Member

I had a few problems when I tried to do this. The first is that you need to fix the isFlying() method. It's a quick fix and you can copy that from my PR for this issue.

The next problem is that when you open the parameters activity in the middle of a parameters download, the progress bar doesn't show up, and you won't even know it's in progress. So if the first thing you do after connecting is change parameters, you won't know that the parameters are already downloading.

The last thing is that when you don't realize that a param download is in progress, you might click the button to start a new param download. This makes a huge mess.

Those last two things were problems that existed way before, but the problem became more obvious when params start downloading automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants