Sort workflow versions based on SemVer parts #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds versionSort computed field to workflow-version following the sorting pattern used in bespin-api for sorting workflow-versions. Changes version sorting to use this new field for routes: - /new/select-workflow-version/<workflow_id> - select a workflow version - /workflows - lists workflow versions for each workflow Started using @each annotation to populate 'version' field in computed lists: https://guides.emberjs.com/v2.12.0/object-model/computed-properties-and-aggregate-data/ The bug in question was only visible when viewing cached workflow versions due to sorting done by bespin-api and the 'version' fields being null during sort('version') operation.
dleehr
approved these changes
Jun 13, 2019
There was a problem hiding this comment.
I had an existing branch to fix this issue but never made it to a PR -148-fix-version-sort. At first I was confused about how you created a different branch with the same name, but I see this one has a small typo.
Mine didn't make it into a PR yet is because of PhantomJS issues (referenced in #154) about padStart, but it looks like you found another package to address that.
It's interesting to see the different approaches though :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds versionSort computed field to workflow-version following the
sorting pattern used in bespin-api for sorting workflow-versions.
Changes version sorting to use this new field for routes:
Started using @each annotation to populate 'version' field in computed lists:
https://guides.emberjs.com/v2.12.0/object-model/computed-properties-and-aggregate-data/
The bug in question was only visible when viewing cached workflow versions due to
sorting done by bespin-api and the 'version' fields being null during
sort('version') operation.
Added
ember-padto work around PhantomJS missing String.padStart.Fixes #148