Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scrollbar bug fixed #543

Merged
merged 2 commits into from
Oct 24, 2023
Merged

fix: scrollbar bug fixed #543

merged 2 commits into from
Oct 24, 2023

Conversation

Aryakoste
Copy link
Contributor

Fixes Issue #536

**My PR closes #536

πŸ‘¨β€πŸ’» Changes proposed(What did you do ?)

  • The fontsize of text inside the textarea was 18px + padding bottom(10px) + padding top(10px) it is 48 which is higher than its acutual height which is 45px so i increased it to 48px for the content to not overflow.
  • I set overflow auto to both chat input and chat container which will only show scrollbar when the content overflows the container which solves the problem.

βœ”οΈ Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.

Note to reviewers

πŸ“· Screenshots

image

@vercel
Copy link

vercel bot commented Oct 24, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @Dun-sin on Vercel.

@Dun-sin first needs to authorize it.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@Aryakoste Aryakoste changed the title fix: scrollbar bug fixed fix: scrollbar bug fixed Oct 24, 2023
@vercel
Copy link

vercel bot commented Oct 24, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
whisper βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Oct 24, 2023 1:23pm

@Dun-sin
Copy link
Owner

Dun-sin commented Oct 24, 2023

Copy link
Owner

@Dun-sin Dun-sin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did great, thanks for contributing, I hope you will stick around and continue to contribute to this project.

Consider giving this project a star and joining the community discord server if you haven't for more resources and opportunities to connect with others. πŸ‘‰πŸ½hereπŸ‘ˆπŸ½

@Dun-sin Dun-sin merged commit 1ba5c94 into Dun-sin:main Oct 24, 2023
1 of 2 checks passed
@Dun-sin Dun-sin mentioned this pull request Aug 19, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Scrollbar effect
2 participants