Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: close dialog after logging out #673

Merged
merged 3 commits into from
Aug 19, 2024

Conversation

malakbenr
Copy link
Contributor

@malakbenr malakbenr commented Aug 18, 2024

Fixes Issue

*My PR closes #644

👨‍💻 Changes proposed(What did you do ?)

  • I closed the dialog after logging out by by updating the state of setDialog in the logOut function.

✔️ Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.

Note to reviewers

📷 Screenshots

@Dun-sin
Copy link
Owner

Dun-sin commented Aug 19, 2024

Please edit your PR adding what you did to fix the issue, this is to help with documentation here's an example: #543

You don't need to close the PR just edit the current one

@malakbenr
Copy link
Contributor Author

Please edit your PR adding what you did to fix the issue, this is to help with documentation here's an example: #543

You don't need to close the PR just edit the current one

Done.

Copy link

vercel bot commented Aug 19, 2024

@Dun-sin is attempting to deploy a commit to the dunsin's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Owner

@Dun-sin Dun-sin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did great, thanks for contributing, I hope you will stick around and continue to contribute to this project.

Consider giving this project a star, sharing the project with your friends, and joining the community discord server if you haven't for more resources and opportunities to connect with others. 👉🏽here👈🏽

@Dun-sin Dun-sin merged commit 4ee0b25 into Dun-sin:main Aug 19, 2024
1 of 3 checks passed
@malakbenr
Copy link
Contributor Author

You did great, thanks for contributing, I hope you will stick around and continue to contribute to this project.

Consider giving this project a star, sharing the project with your friends, and joining the community discord server if you haven't for more resources and opportunities to connect with others.

Thank you for the kind words! I'm really glad to have been able to contribute to this project and look forward to continuing to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] logout dialogue still showing after user has logged out
2 participants