Skip building arrays for surface absorption when surface fluxes are disabled #6065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbegeman
added
MPAS-Ocean standalone
|
@jonbob and @mark-petersen No rush on this. It's just a small change that is convenient for certain standalone cases. |
|
@mark-petersen please review when you can. |
mark-petersen
approved these changes
Dec 21, 2023
There was a problem hiding this comment.
This looks great. Thanks @cbegeman for your code improvement and attention to detail. I agree that the forcing arrays do not need to be built when surfaces fluxes are off. I also checked that the initialized arrays are not used anywhere else when either config_disable_thick_sflux or config_disable_tr_sflux are true.
|
@mark-petersen Thank you for reviewing! |
jonbob
added a commit
that referenced
this pull request
Jan 3, 2024
Skip building arrays for surface absorption when surface fluxes are disabled When both thickness and tracer surface fluxes are disabled with the config_disable_* flags, skip building the transmission coefficient arrays and related arrays. [BFB] mpaso standalone only
|
passes:
merged to next |
|
@jonbob Thank you for your testing! |
|
merged to master |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When both thickness and tracer surface fluxes are disabled with the
config_disable_*flags, skip building the transmission coefficient arrays and related arrays.