Sfr fixes part 2 #52
Open
Sfr fixes part 2 #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…opens the search modal
alaninnovates
force-pushed
the
sfr-fixes-part-2
branch
from
db3cfbf
to
5a9fb93
Compare
|
uhhh i have no idea what i did but the code still works at least |
Versus7
requested changes
Apr 11, 2024
| const {colors} = useTheme(); | ||
| const [content, setContent] = useState<string>(note.content); | ||
|
|
||
| const saveNote = async () => { |
There was a problem hiding this comment.
Bug: not actually saving to DB. Judging by the RLS, I would guess it's because you need a policy allowing authenticated users to update their notes.
| onSave({...note, content}); | ||
| }; | ||
|
|
||
| const styles = StyleSheet.create({ |
There was a problem hiding this comment.
not a huge fan of how much space there is underneath the save button. maybe rewrite using KeyboardAvoidingView?
| console.log('storedFormData: ', storedFormData); | ||
| if (storedFormData != null) { | ||
| const data = JSON.parse(storedFormData); | ||
| setArrayData(data.arrayData); |
There was a problem hiding this comment.
There should be a toast or some other indicator to the user that the form was loaded from offline storage / cache (use a more user-friendly term for this).
| }} | ||
| onLongPress={() => { | ||
| if (!('id' in item)) { | ||
| Alert.alert('You cannot edit an offline note!'); |
There was a problem hiding this comment.
Why can you not edit an offline note?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.