Sfr fixes part 2 #52
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,152 @@ | ||
| import { | ||
| Modal, | ||
| Pressable, | ||
| StyleSheet, | ||
| Text, | ||
| TextInput, | ||
| View, | ||
| } from 'react-native'; | ||
| import {useTheme} from '@react-navigation/native'; | ||
| import {useState} from 'react'; | ||
| import {NoteStructureWithMatchNumber} from '../../database/Notes'; | ||
| import Svg, {Path} from 'react-native-svg'; | ||
| import {supabase} from '../../lib/supabase'; | ||
|
|
||
| export const EditNoteModal = ({ | ||
alaninnovates marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| visible, | ||
| note, | ||
| onSave, | ||
| onCancel, | ||
| }: { | ||
| visible: boolean; | ||
| note: NoteStructureWithMatchNumber; | ||
| onSave: (note: NoteStructureWithMatchNumber) => void; | ||
| onCancel: () => void; | ||
| }) => { | ||
| const {colors} = useTheme(); | ||
| const [content, setContent] = useState<string>(note.content); | ||
|
|
||
| const saveNote = async () => { | ||
|
There was a problem hiding this comment. Bug: not actually saving to DB. Judging by the RLS, I would guess it's because you need a policy allowing authenticated users to update their notes. 
|
||
| await supabase.from('notes').update({content}).eq('id', note.id); | ||
| // await supabase.from('notes_edits').insert({ | ||
| // note_id: note.id, | ||
| // content: note.content, | ||
| // new_content: content, | ||
| // }); | ||
| onSave({...note, content}); | ||
| }; | ||
|
|
||
| const styles = StyleSheet.create({ | ||
|
There was a problem hiding this comment. not a huge fan of how much space there is underneath the save button. maybe rewrite using KeyboardAvoidingView? |
||
| container: { | ||
| flex: 1, | ||
| justifyContent: 'center', | ||
| alignItems: 'center', | ||
| }, | ||
| modal: { | ||
| backgroundColor: colors.card, | ||
| padding: 20, | ||
| borderRadius: 10, | ||
| width: '80%', | ||
| }, | ||
| backgroundCovering: { | ||
| backgroundColor: 'rgba(0, 0, 0, 0.5)', | ||
| position: 'absolute', | ||
| top: 0, | ||
| right: 0, | ||
| bottom: 0, | ||
| left: 0, | ||
| }, | ||
| input: { | ||
| backgroundColor: colors.background, | ||
| padding: 10, | ||
| borderRadius: 5, | ||
| marginVertical: 10, | ||
| height: '30%', | ||
| color: colors.text, | ||
| }, | ||
| button: { | ||
| backgroundColor: colors.primary, | ||
| padding: 10, | ||
| borderRadius: 5, | ||
| marginVertical: 10, | ||
| alignItems: 'center', | ||
| }, | ||
| disabledButton: { | ||
| backgroundColor: 'gray', | ||
| padding: 10, | ||
| borderRadius: 5, | ||
| marginVertical: 10, | ||
| alignItems: 'center', | ||
| }, | ||
| buttonText: { | ||
| color: colors.background, | ||
| }, | ||
| }); | ||
|
|
||
| return ( | ||
| <Modal animationType="slide" transparent={true} visible={visible}> | ||
| <View style={styles.backgroundCovering} /> | ||
| <View style={styles.container}> | ||
| <View style={styles.modal}> | ||
| <View | ||
| style={{ | ||
| display: 'flex', | ||
| flexDirection: 'row', | ||
| justifyContent: 'space-between', | ||
| alignItems: 'center', | ||
| }}> | ||
| <Text | ||
| style={{color: colors.text, fontWeight: 'bold', fontSize: 24}}> | ||
| Edit Note | ||
| </Text> | ||
| <View | ||
| style={{ | ||
| flex: 1, | ||
| }} | ||
| /> | ||
| <Pressable | ||
| onPress={onCancel} | ||
| style={{ | ||
| backgroundColor: colors.notification, | ||
| padding: 10, | ||
| borderRadius: 100, | ||
| alignItems: 'center', | ||
| }}> | ||
| <Svg width="24" height="24" viewBox="0 0 24 24" fill="none"> | ||
| <Path | ||
| d="M6 18L18 6M6 6l12 12" | ||
| stroke="white" | ||
| strokeWidth="2" | ||
| strokeLinecap="round" | ||
| strokeLinejoin="round" | ||
| /> | ||
| </Svg> | ||
| </Pressable> | ||
| </View> | ||
| <Text style={{color: colors.text, fontSize: 18}}> | ||
| Match: {note.match_number} | ||
| </Text> | ||
| <Text style={{color: colors.text, fontSize: 18}}> | ||
| Team: {note.team_number} | ||
| </Text> | ||
| <TextInput | ||
| style={styles.input} | ||
alaninnovates marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| multiline={true} | ||
| value={content} | ||
| onChange={e => setContent(e.nativeEvent.text)} | ||
| /> | ||
| <Pressable | ||
| style={ | ||
| !content || content === note.content | ||
| ? styles.button | ||
| : styles.disabledButton | ||
| } | ||
| onPress={saveNote} | ||
| disabled={!content || content === note.content}> | ||
| <Text style={styles.buttonText}>Save</Text> | ||
| </Pressable> | ||
| </View> | ||
| </View> | ||
| </Modal> | ||
| ); | ||
| }; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why can you not edit an offline note?