Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove leaflet content #117

Open
3 tasks
bwbohl opened this issue Sep 27, 2017 · 7 comments · May be fixed by #445
Open
3 tasks

remove leaflet content #117

bwbohl opened this issue Sep 27, 2017 · 7 comments · May be fixed by #445
Assignees
Milestone

Comments

@bwbohl
Copy link
Member

bwbohl commented Sep 27, 2017

[UPDATED ISSUE DESCRIPTION]
We decided to deprecate leaflet support in Edirom Online. Consequently it should be completely removed from the develop branch. That includes:

  • removing leaflet source files (JS)
  • removing leaflet switches from JS files
  • removing it from edirom_prefs.xml

For some advice on where and how to locate leaflet stuff, see below comments.

[ORIGINAL ISSUE DESCRIPTION]
When using leaflet as image server the annotationView will initially load properly for a single annotation in grid view. But it fails when switching to single or list view.

  1. no facsimiles will be shown or listed
  2. when switching back to grid the grid will be empty
  3. when going back to all annotations list and then reopening the annotation from before it will not show any facsimile in any grid|single|list view
@bwbohl bwbohl added this to the images, viewers, servers milestone Feb 9, 2022
@krHERO
Copy link
Member

krHERO commented May 30, 2024

@bwbohl can we close this issue because of deprecation of leaflet?

@daniel-jettka daniel-jettka modified the milestones: images, viewers, servers, 1.0.0-beta.6 Jun 3, 2024
@bwbohl
Copy link
Member Author

bwbohl commented Jun 4, 2024

if we're all 100% to deprecate leaflet then yes.

@krHERO
Copy link
Member

krHERO commented Jun 7, 2024

at our last edirom community meeting 5.6.2024, we agreed: not leaflet itself is deprecated but the current edirom online is and will not use leaflat anymore. for this reason, i will change the title of this issue to delete anything regarding leaflet in the code.

@krHERO krHERO changed the title annotationView leaflet switch grid single list remove leaflet content Jun 7, 2024
@bwbohl
Copy link
Member Author

bwbohl commented Jun 26, 2024

find . -name '*leaflet*'
./resources/leaflet-1.0.0-b1
./resources/leaflet-1.0.0-b1/leaflet.js
./resources/leaflet-1.0.0-b1/leaflet.css
./resources/leaflet-1.0.0-b1/leaflet-src.js
./resources/leaflet-0.7.3
./resources/leaflet-0.7.3/leaflet.js
./resources/leaflet-0.7.3/leaflet.css
./resources/leaflet-0.7.3/leaflet-src.js
./resources/Leaflet.tooltip-master/dist/leaflet.tooltip.js
./resources/Leaflet.tooltip-master/dist/leaflet.tooltip.css

@bwbohl
Copy link
Member Author

bwbohl commented Jun 26, 2024

grep -R  "leaflet" app/*
app/view/window/source/MeasureBasedView.js:    	if(image_server === 'leaflet'){
app/view/window/source/MeasureBasedView.js:       		if(image_server === 'leaflet'){
app/view/window/source/MeasureBasedView.js:            if(group.measures[0]['path'] != viewer.imgPath || image_server === 'leaflet') {
app/view/window/source/MeasureBasedView.js: 			if(image_server === 'leaflet'){   
app/view/window/source/PageBasedView.js:    	if(image_server === 'leaflet'){
app/view/window/source/PageBasedView.js:            if(image_server === 'leaflet'){   
app/view/window/image/LeafletFacsimile.js: * @classdesc EdiromOnline.view.window.image.LeafletFacsimile for create leaflet component.
app/view/window/image/LeafletFacsimile.js:	alias: 'widget.leafletmapview',
app/view/window/image/LeafletFacsimile.js:	 * create leaflet
app/view/window/image/LeafletFacsimile.js:		var leafletRef = window.L;
app/view/window/image/LeafletFacsimile.js:		if (leafletRef == null) {
app/view/window/image/LeafletFacsimile.js:			this.update('No leaflet library loaded');
app/view/window/image/LeafletFacsimile.js:		var leaflet_path = null;
app/view/window/image/LeafletFacsimile.js:			leaflet_path = fields[0];
app/view/window/image/LeafletFacsimile.js:			var leaflet_prefix = getPreference('leaflet_prefix');
app/view/window/image/LeafletFacsimile.js:			leaflet_path = leaflet_prefix + name;
app/view/window/image/LeafletFacsimile.js:		L.tileLayer.facsimileLayer(leaflet_path + '/{z}-{x}-{y}.jpg', {
app/view/window/AnnotationView.js:        if (me.image_server === 'leaflet') {		
app/view/window/SummaryView.js:		if (me.image_server === 'leaflet') {
app/view/window/SummaryView.js:		if (me.image_server === 'leaflet' && typeof name !== 'undefined') {
app/view/window/text/FacsimileView.js:        if (image_server === "leaflet") {
app/view/window/text/TextFacsimileSplitView.js:    	if(me.image_server === 'leaflet'){

@bwbohl bwbohl added the Area: JS label Jul 3, 2024
@bwbohl bwbohl modified the milestones: 1.0.0-beta.6, 1.0.0 Sep 4, 2024
@bwbohl
Copy link
Member Author

bwbohl commented Sep 12, 2024

<!--<entry key="leaflet_prefix" value="/exist/rest/db/contents/leafletImages/"/>

@daniel-jettka
Copy link
Contributor

grep -R  "leaflet" add/*
add/data/xslt/tei/Stylesheets/Test/mediawiki1.xml:90% of the BNC is samples of [[written language]] use. These samples were extracted from regional and national newspapers, published research journals or periodicals from various academic fields, both fiction and non-fiction books, both published and unpublished material such as leaflets, brochures, letters, essays written by students of differing academic levels, speeches, scripts and many other types of texts.&lt;ref name=&quot;gloriacappelli&quot;&gt;[http://www.gloriacappelli.it/wp-content/uploads/2007/05/bnc.pdf ''British National Corpus'']. Retrieved 12 March 2012.&lt;/ref&gt;
add/data/xql/edirom_printPreview.xql:declare variable $facsBasePath := if ($imageserver = 'leaflet')
add/data/xql/edirom_printPreview.xql:    (eutil:getPreference('leaflet_prefix', $edition))
add/data/xql/getReducedDocument.xql:    if ($imageserver = 'leaflet') then
add/data/xql/getReducedDocument.xql:        (eutil:getPreference('leaflet_prefix', $edition))
add/data/xql/getAnnotationPreviews.xql:declare variable $imageBasePath := if ($imageserver = 'leaflet') then
add/data/xql/getAnnotationPreviews.xql:    (eutil:getPreference('leaflet_prefix', $edition))
add/data/xql/getAnnotationPreviews.xql:        if ($imageserver = 'leaflet') then
add/data/xql/getAnnotationPreviews.xql:                case 'leaflet'
add/data/xql/getText.xql:    if ($imageserver = 'leaflet') then
add/data/xql/getText.xql:    (eutil:getPreference('leaflet_prefix', $edition))
add/data/xql/getAnnotation.xql:    if ($imageserver = 'leaflet') then
add/data/xql/getAnnotation.xql:        (eutil:getPreference('leaflet_prefix', $edition))
add/data/xql/getSummary.xql:    let $i_path := if ($server = 'leaflet') then
add/data/xql/getSummary.xql:        (eutil:getPreference('leaflet_prefix', $edition))
add/data/xql/getSummary.xql:        if ($server = 'leaflet') then
add/data/xql/getSummary.xql:            if ($server = 'leaflet') then
add/data/xqm/annotation.xqm:        if($imageserver = 'leaflet') then
add/data/xqm/annotation.xqm:            (eutil:getPreference('leaflet_prefix', $edition))
add/data/prefs/edirom-prefs.xml:        <!--<entry key="leaflet_prefix" value="/exist/rest/db/contents/leafletImages/"/>
add/data/prefs/edirom-prefs.xml:        <entry key="image_server" value="leaflet"/>-->
add/index.xql:                            <link rel="stylesheet" href="resources/leaflet-0.7.3/leaflet.css"/>
add/index.xql:                            <link rel="stylesheet" href="resources/Leaflet.tooltip-master/dist/leaflet.tooltip.css"/>
add/index.xql:                            <script type="text/javascript" src="resources/leaflet-0.7.3/leaflet.js"/>
add/index.xql:                            <script src="resources/Leaflet.tooltip-master/dist/leaflet.tooltip.js"/>

@daniel-jettka daniel-jettka linked a pull request Oct 11, 2024 that will close this issue
@daniel-jettka daniel-jettka linked a pull request Oct 11, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

4 participants