Ftr/117 remove leaflet #445
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
@bwbohl Could you have a look at this? I am not sure how to check if everything's working fine after removing all leaflet content - I mean it wasn't in use anyway, right? |
There was a problem hiding this comment.
I was trying to test this PR with the clarinet quintet data I grabbed from the pipeline build.
First I was hit by the error #443 reported by @roewenstrunk so I had to merge his fix into this branch. Then I was able to take a look and it all seemed to work (i.e. I did no systematic tests).
peterstadler
force-pushed
the
ftr/117-remove-leaflet
branch
from
6162596
to
c42a787
Compare
|
I rebased this branch to bring it up to date with current dev. Please make sure to
|
peterstadler
force-pushed
the
ftr/117-remove-leaflet
branch
from
c42a787
to
f1ffd99
Compare
| <link rel="stylesheet" href="resources/leaflet-0.7.3/leaflet.css"/> | ||
| <link rel="stylesheet" href="resources/Leaflet.tooltip-master/dist/leaflet.tooltip.css"/> | ||
| <script type="text/javascript" src="resources/leaflet-0.7.3/leaflet.js"/> | ||
| <script type="text/javascript" src="resources/facsimileLayer/FacsimileLayer.js"/> |
There was a problem hiding this comment.
is FacsimileLayer.js not needed anymore?
| @@ -23,7 +23,6 @@ Ext.define("EdiromOnline.view.window.text.FacsimileView", { | |||
| requires: [ | |||
| "EdiromOnline.view.window.image.ImageViewer", | |||
| "EdiromOnline.view.window.image.OpenSeaDragonViewer", | |||
There was a problem hiding this comment.
Comma should be removed:
Suggested change
| "EdiromOnline.view.window.image.OpenSeaDragonViewer", | |
| "EdiromOnline.view.window.image.OpenSeaDragonViewer" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description, Context and related Issue
Removed all leaflet files and content because Edirom does not support leaflet anymore.
Refs #117
How Has This Been Tested?
(...)
Types of changes