Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

init: elip for discounted CT #16

Merged
merged 1 commit into from
Jun 22, 2024
Merged

init: elip for discounted CT #16

merged 1 commit into from
Jun 22, 2024

Conversation

delta1
Copy link
Member

@delta1 delta1 commented Jun 19, 2024

first pass at ELIP for discounted CT as implemented in ElementsProject/elements#1317 and alternate implementation in ElementsProject/rust-elements#204

@apoelstra
Copy link
Member

3b286ea looks good to me except that it should have explicit test vectors.

@delta1
Copy link
Member Author

delta1 commented Jun 20, 2024

thanks @apoelstra. should they be inline or as separate files?

what number should be used for this ELIP?

@apoelstra
Copy link
Member

I would put them inline.

This can have number 200. (For transparency -- I am just picking a number "far away" from existing BIPs which don't seem to resemble this one, and I don't have any secret table of predetermined number ranges.)

@delta1
Copy link
Member Author

delta1 commented Jun 21, 2024

added test vectors and used number 200

apoelstra
apoelstra approved these changes Jun 22, 2024
View reviewed changes
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 33e5c4d -- did not verify the test vectors

@apoelstra
Copy link
Member

Gonna go ahead and merge this. Can do followup PRs when people start reimplementing this, if there is feedback.

@apoelstra apoelstra merged commit 341bafd into ElementsProject:main Jun 22, 2024
@delta1 delta1 mentioned this pull request Aug 13, 2024
Merged
apoelstra added a commit that referenced this pull request Aug 13, 2024
@apoelstra
Merge #19: readme: add elip 200
6ebfb95 
f139571 readme: add elip 200 (Byron Hambly)

Pull request description:

  forgot to add TOC entry with #16

ACKs for top commit:
  apoelstra:
    ACK f139571

Tree-SHA512: e75a6462b4cc1430cc8d4c902da4b911503211aa94024fcb2aa5f842986ffc9e49c02dbb42a950510ebd32827c21a3765261c449e83acabedefbe606df8ac7cb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoelstra apoelstra apoelstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@delta1 @apoelstra