tx: add discount_weight and discount_vsize #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 19, 2024
apoelstra
added a commit
to ElementsProject/ELIPs
that referenced
this pull request
Jun 22, 2024
33e5c4d ELIP-0200: Discounted fees for Confidential Transactions (Byron Hambly) Pull request description: first pass at ELIP for discounted CT as implemented in ElementsProject/elements#1317 and alternate implementation in ElementsProject/rust-elements#204 ACKs for top commit: apoelstra: utACK 33e5c4d -- did not verify the test vectors Tree-SHA512: 1c2d10a7e6ae0750e53e2364f4a55a767fa99d600bf5a9eaa04f3b06d906e618c6b9f0097ab829c651a3152cf5e0475109de045b8c9109892cea81844893a000
|
Needs rebase. |
|
@apoelstra rebased |
apoelstra
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds implementation of discount virtual size from ElementsProject/elements#1317
same test vectors in ElementsProject/elements#1341