Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node_announcement propagation has gotten worse! #5196

Closed
rustyrussell opened this issue Apr 19, 2022 · 3 comments
Closed

node_announcement propagation has gotten worse! #5196

rustyrussell opened this issue Apr 19, 2022 · 3 comments
Assignees
@rustyrussell
Labels
gossip
Milestone
v0.11

Comments

@rustyrussell
Copy link
Contributor

Two examples: my node, which is running v0.11.0rc3+, and IRATEMONKEY, which is the same:

https://1ml.com/node/024b9a1fa8e006f1e3937f65f66c408e6da8e1ca728ea43222a7381df1cc449605
https://amboss.space/node/024b9a1fa8e006f1e3937f65f66c408e6da8e1ca728ea43222a7381df1cc449605
https://lightningnetwork.plus/nodes/024b9a1fa8e006f1e3937f65f66c408e6da8e1ca728ea43222a7381df1cc449605

https://1ml.com/node/032de5c0f28f9d7d10c0c0b5ec92e83f9bf40def2bf40181c0f4330c57e58a8605
https://amboss.space/node/032de5c0f28f9d7d10c0c0b5ec92e83f9bf40def2bf40181c0f4330c57e58a8605
https://lightningnetwork.plus/nodes/032de5c0f28f9d7d10c0c0b5ec92e83f9bf40def2bf40181c0f4330c57e58a8605

You can see these (despite upgrading) are still not having their node_announcements propagating.
@rustyrussell rustyrussell added this to the v0.11 milestone Apr 19, 2022
@rustyrussell rustyrussell self-assigned this Apr 19, 2022
@rustyrussell rustyrussell mentioned this issue Apr 19, 2022
Closed
@rustyrussell
Copy link
Contributor Author

This seems to be an issue with LND not liking the draft websocket address extension.

rustyrussell added a commit to rustyrussell/lightning that referenced this issue Apr 19, 2022
@rustyrussell
connectd: disable advertizement of WEBSOCKET addresses.
077a54a 
This seems to prevent broad propagation, due to LND not allowing it.  See
	lightningnetwork/lnd#6432

We still announce it if you disable deprecated-apis, so tests still work,
and hopefully we can enable it in future.

Fixes: ElementsProject#5196
Signed-off-by: Rusty Russell <[email protected]>
@rustyrussell rustyrussell mentioned this issue Apr 19, 2022
Merged
rustyrussell added a commit to rustyrussell/lightning that referenced this issue Apr 19, 2022
@rustyrussell
connectd: disable advertizement of WEBSOCKET addresses.
12c96f2 
This seems to prevent broad propagation, due to LND not allowing it.  See
	lightningnetwork/lnd#6432

We still announce it if you disable deprecated-apis, so tests still work,
and hopefully we can enable it in future.

Fixes: ElementsProject#5196
Signed-off-by: Rusty Russell <[email protected]>
Changelog-EXPERIMENTAL: Protocol: disabled websocket announcement due to LND propagation issues
rustyrussell added a commit to rustyrussell/lightning that referenced this issue Apr 20, 2022
@rustyrussell
connectd: disable advertizement of WEBSOCKET addresses.
5b98323 
This seems to prevent broad propagation, due to LND not allowing it.  See
	lightningnetwork/lnd#6432

We still announce it if you disable deprecated-apis, so tests still work,
and hopefully we can enable it in future.

Fixes: ElementsProject#5196
Signed-off-by: Rusty Russell <[email protected]>
Changelog-EXPERIMENTAL: Protocol: disabled websocket announcement due to LND propagation issues
rustyrussell added a commit to rustyrussell/lightning that referenced this issue Apr 20, 2022
@rustyrussell
connectd: disable advertizement of WEBSOCKET addresses.
5db0d25 
This seems to prevent broad propagation, due to LND not allowing it.  See
	lightningnetwork/lnd#6432

We still announce it if you disable deprecated-apis, so tests still work,
and hopefully we can enable it in future.

Fixes: ElementsProject#5196
Signed-off-by: Rusty Russell <[email protected]>
Changelog-EXPERIMENTAL: Protocol: disabled websocket announcement due to LND propagation issues
@carnhofdaki
Copy link

Thanks!

@jsarenik
Copy link
Collaborator

@fiatjaf Could this be related to issues with https://ln.fiatjaf.com/node/032de5c0f28f9d7d10c0c0b5ec92e83f9bf40def2bf40181c0f4330c57e58a8605 ?

Same for the other node: https://ln.fiatjaf.com/node/024b9a1fa8e006f1e3937f65f66c408e6da8e1ca728ea43222a7381df1cc449605

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rustyrussell rustyrussell

Labels
gossip
Projects
None yet
Milestone
v0.11
Development

No branches or pull requests
3 participants
@jsarenik @rustyrussell @carnhofdaki