connectd: fix and further enhance our own gossip promotion #5200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This attempted to make us re-xmit our own node_announcement at restart, by moving the node_announcement to the end of the gossip store. But, as nothing is connected, yet, this had no effect! We will rexmit it anyway, since it's marked PUSH. Signed-off-by: Rusty Russell <[email protected]>
These are the ones which are for our own channels (and our own node_announcement). Signed-off-by: Rusty Russell <[email protected]>
…ter. We seem to have made node_announcement propagation *worse*, not better. Explorers don't see my nodes updates. At least some LND nodes never send us timestamp_filter, so we are never actually stream *any* gossip. We should send gossip about ourselves, even if they haven't set a filter (yet). Signed-off-by: Rusty Russell <[email protected]> Changelog-Added: Protocol: we more aggressively send our own gossip, to improve propagation chances.
We have an explicit filter against redundant node_announcement updates; we only allow 1 a week. This means that our change to force a reannouncement every 24 hours did not work! Allow once a day, instead. Signed-off-by: Rusty Russell <[email protected]>
We shorten 24 hours to 24 seconds using --dev--fast-gossip-prune. Signed-off-by: Rusty Russell <[email protected]>
Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
force-pushed
the
guilt/connectd-always-send-local-gossip
branch
2 times, most recently
from
12c96f2
to
5b98323
Compare
|
ACK 5b98323 Will see if CI is just flaky or really has some issues. |
|
Unsurprisingly |
This seems to prevent broad propagation, due to LND not allowing it. See lightningnetwork/lnd#6432 We still announce it if you disable deprecated-apis, so tests still work, and hopefully we can enable it in future. Fixes: ElementsProject#5196 Signed-off-by: Rusty Russell <[email protected]> Changelog-EXPERIMENTAL: Protocol: disabled websocket announcement due to LND propagation issues
rustyrussell
force-pushed
the
guilt/connectd-always-send-local-gossip
branch
from
5b98323
to
5db0d25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The #5196 issue had me look harder at the propagation improvements, and doing some real life testing.
This is a larger PR than I would have liked, but the previous propagation "improvements" were woefully under tested. That's my fault, as I figured they couldn't make things worse (true, but they didn't make things better either!).