Take hsm_secret password from stdin, even for hsmtool! #4303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darosior
force-pushed
the
hsmtool_nopass
branch
3 times, most recently
from
3255bc1
to
54b97be
Compare
|
Travis failure is just a one job timeout https://travis-ci.org/github/ElementsProject/lightning/jobs/752638311 |
This slightly breaks the API, but still accept the input: we just don't take it into account anymore. For `dumponchaindescriptors`, we have to still take the old place of the `network` parameter into account to not entirely break the API. Changelog-Added: hsmtool: password must now be entered on stdin. Password passed on the command line are discarded. Signed-off-by: Antoine Poinsot <[email protected]>
Signed-off-by: Antoine Poinsot <[email protected]>
darosior
force-pushed
the
hsmtool_nopass
branch
from
54b97be
to
dc1132d
Compare
|
ACK dc1132d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4186, based on #4284
Went for the procedure here for the API break. Should we instead support both for 3 releases ? It seemed overkill to me as it's a command-line tool and worse case the user has to input their password twice.