Hsmtool (and hsm_secret encryption) refactorings #4307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darosior
force-pushed
the
hsmtool_refactor
branch
from
f799cfb
to
b0e3244
Compare
errx() was printing the confusing errno as well ("Error could not [...] :Success")
Signed-off-by: Antoine Poinsot <[email protected]>
Changelog-changed: lightningd: the `--encrypted-hsm` now asks you to confirm your password when first set Changelog-changed: hsmtool: the `encrypt` now asks you to confirm your password Signed-off-by: Antoine Poinsot <[email protected]>
This avoids duplication of both logic and error-prone values, such as the salt. Grouping all hsm encryption logic into a public API will also allow us to fuzz it. Signed-off-by: Antoine Poinsot <[email protected]>
Signed-off-by: Antoine Poinsot <[email protected]>
Signed-off-by: Antoine Poinsot <[email protected]>
Signed-off-by: Antoine Poinsot <[email protected]>
This makes use of the constant defined in the previous commits to more accurately detect plaintext, encrypted, and invalid seeds. We now error on invalid seeds. Changelog-changed: hsmd: we now error at startup on invalid hsm_secret Changelog-changed: hsmtool: all commands now error on invalid hsm_secret Signed-off-by: Antoine Poinsot <[email protected]>
It's more useful if we actually want to use the output as, well, a string.. Signed-off-by: Antoine Poinsot <[email protected]>
Signed-off-by: Antoine Poinsot <[email protected]>
cdecker
force-pushed
the
hsmtool_refactor
branch
from
b0e3244
to
dc5c2db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bunch of cleanups on top of #4303 .
Mainly, this makes the
hsm_encryptioncontained into a common/ module, shared byhsmd,lightningd(options and hsm_control) andhsmtool. This then allows us to fuzz a roundtrip sanity check of our encryption.Also:
hsmtoolencryptinhsmtoolhsm_secretvalidity (only accept 32-bytes (plaintext) and 73-bytes (encrypted) seeds)There are still some cleanups left to be done (the channel seed derivation function is still duplicated, we could use
optfor argument parsing).