Regtest fee control #4629
Merged
Regtest fee control #4629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
force-pushed
the
guilt/regtest-feecontrol
branch
from
937dcc5
to
6239684
Compare
|
Thanks, that sounds perfect for the tests I'm doing. |
|
ACK 6239684 |
rustyrussell
force-pushed
the
guilt/regtest-feecontrol
branch
from
6239684
to
431bb42
Compare
This has been reported several times on regtest, most recently by Gijs van Dam. It turns out approx_max_feerate() was returning 0 in some corner cases: we should *not* be using that value (as shown, it's overly conservative) except as a ceiling on fee *increases*. Signed-off-by: Rusty Russell <[email protected]> Changelog-Fixed: Protocol: don't ever send 0 fee_updates (regtest bug).
Useful for regtest and testnet. Sure, you shouldn't use this on mainnet, but I haven't restricted it because our users are usually pretty clever. Signed-off-by: Rusty Russell <[email protected]> Fixes: ElementsProject#1806 Changelog-Added: config: `force_feerates` option to allow overriding feerate estimates (mainly for regtest).
rustyrussell
force-pushed
the
guilt/regtest-feecontrol
branch
from
431bb42
to
52b1518
Compare
'force-feerates' already bypasses this logic, but we should still suppres Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
force-pushed
the
guilt/regtest-feecontrol
branch
from
52b1518
to
e55363b
Compare
|
Ack e55363b Rebased and fixed (and commented!) code which makes sure we don't reduce, if we're trying to increase and max says were too high already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got a report from @gijswijs that we were sending 0 update_fee on regtest; I've seen this complaint before, but this time we fixed it.
Also, @t-bast wanted to override regtest fees: we used to have a dev option which we removed in favor of direct control, I think that was probably overzealous (it's far easier that writing a bcli replacement!). Of course we recommend this be in the regtest-specific config!