rpc: use the standard port derivation in connect command #5242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincenzopalazzo
force-pushed
the
macros/dafault_port
branch
from
7746843
to
dbc4c6c
Compare
vincenzopalazzo
changed the title
vincenzopalazzo
force-pushed
the
macros/dafault_port
branch
from
dbc4c6c
to
7ffd207
Compare
cdecker
reviewed
May 7, 2022
vincenzopalazzo
force-pushed
the
macros/dafault_port
branch
2 times, most recently
from
b2bb0cb
to
c60287b
Compare
vincenzopalazzo
force-pushed
the
macros/dafault_port
branch
2 times, most recently
from
de82bf1
to
4911862
Compare
|
Second commit fixes up mistakes in the first: please clean that up! Results look good though! |
vincenzopalazzo
force-pushed
the
macros/dafault_port
branch
from
4911862
to
f18bc50
Compare
Ops! sorry!
Looks like already done :) seems that I clean up my memory! |
|
Here's a little more documentation: diff --git a/doc/lightning-connect.7.md b/doc/lightning-connect.7.md
index c2e9851f7..ebdc3d8c0 100644
--- a/doc/lightning-connect.7.md
+++ b/doc/lightning-connect.7.md
@@ -18,7 +18,11 @@ be of the form *id@host* or *id@host:port*. In this case, the *host* and
*host* is the peer's hostname or IP address.
-If not specified, the *port* defaults to 9735.
+If not specified, the *port* depends on the current network:
+- **bitcoin** mainnet: 9735.
+- bitcoin **testnet**: 19735.
+- bitcoin **signet**: 39735.
+- bitcoin **regtest**: 19846.
If *host* is not specified (or doesn't work), the connection will be attempted to an IP
belonging to *id* obtained through gossip with other already connected
diff --git a/doc/lightningd-config.5.md b/doc/lightningd-config.5.md
index 5fc07bea9..07388d262 100644
--- a/doc/lightningd-config.5.md
+++ b/doc/lightningd-config.5.md
@@ -370,7 +370,8 @@ network.
Note that for simple setups, the implicit *autolisten* option does the
right thing: for the mainnet (bitcoin) network it will try to bind to
port 9735 on IPv4 and IPv6, and will announce it to peers if it seems
-like a public address.
+like a public address (and other default ports for other networks,
+as described below).
Core Lightning also support IPv4/6 address discovery behind NAT routers.
If your node detects an new public address, it will update its announcement. |
vincenzopalazzo
force-pushed
the
macros/dafault_port
branch
from
f18bc50
to
083cf8d
Compare
|
trivial rebase and docs updated |
rustyrussell
requested changes
Jun 17, 2022
vincenzopalazzo
force-pushed
the
macros/dafault_port
branch
from
083cf8d
to
7ec6353
Compare
vincenzopalazzo
force-pushed
the
macros/dafault_port
branch
from
1380474
to
c0ed812
Compare
vincenzopalazzo
force-pushed
the
macros/dafault_port
branch
10 times, most recently
from
b7b78b6
to
c79bd94
Compare
vincenzopalazzo
force-pushed
the
macros/dafault_port
branch
2 times, most recently
from
8c448e9
to
15b9443
Compare
Complete implementation of BOLT1 port derivation proposal lightning/bolts#968 Changelog-Added: rpc: use the standard port derivation in connect command when the port is not specified. Signed-off-by: Vincenzo Palazzo <[email protected]>
This doesn't make sense, but for now we just keep it Signed-off-by: Vincenzo Palazzo <[email protected]>
Suggested-by: @rustyrussell Signed-off-by: Vincenzo Palazzo <[email protected]> # Title: Signed-off-by: Vincenzo Palazzo <[email protected]>
vincenzopalazzo
force-pushed
the
macros/dafault_port
branch
2 times, most recently
from
5adb0f3
to
2aa523d
Compare
Signed-off-by: Vincenzo Palazzo <[email protected]>
vincenzopalazzo
force-pushed
the
macros/dafault_port
branch
from
2aa523d
to
465e32e
Compare
rustyrussell
requested changes
Jun 26, 2022
rustyrussell
approved these changes
Jun 26, 2022
vincenzopalazzo
force-pushed
the
macros/dafault_port
branch
2 times, most recently
from
7b1d127
to
6eeb74c
Compare
rustyrussell
force-pushed
the
macros/dafault_port
branch
from
6eeb74c
to
173ec20
Compare
|
I fixed the last commit (I was wrong: gossipwith did not set chainparams, which already caused problems, since gossipwith -h would crash!). |
[Also fixes crash with -h, since chainparams was not set! --RR]
rustyrussell
force-pushed
the
macros/dafault_port
branch
from
173ec20
to
90b6cbc
Compare
|
Thanks! Looks like also that the tests related to the network looks good! |
|
Ack 90b6cbc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding the port derivation when the port is not specified in the connect command.
Complete implementation of BOLT1 port derivation proposal lightning/bolts#968
Let's see if some tests in CI will be unhappy
Signed-off-by: Vincenzo Palazzo [email protected]