Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpc: use the standard port derivation in connect command #5242

Merged
merged 6 commits into from
Jun 27, 2022
Merged

rpc: use the standard port derivation in connect command #5242

merged 6 commits into from
Jun 27, 2022

Commits on Jun 25, 2022

  1. lightningd: use the standard port derivation in connect command 

    Complete implementation of BOLT1 port derivation proposal lightning/bolts#968

Changelog-Added: rpc: use the standard port derivation in connect command when the port is not specified.

Signed-off-by: Vincenzo Palazzo <[email protected]>
    @vincenzopalazzo
    vincenzopalazzo committed Jun 25, 2022
    Configuration menu
    Copy the full SHA
    7970b5d View commit details
    Browse the repository at this point in the history

  2. lightningd: change the regtest default port according with the tests 

    This doesn't make sense, but for now we just keep it

Signed-off-by: Vincenzo Palazzo <[email protected]>
    @vincenzopalazzo
    vincenzopalazzo committed Jun 25, 2022
    Configuration menu
    Copy the full SHA
    1b290cc View commit details
    Browse the repository at this point in the history

  3. docs: update the docs in according with the new code 

    Suggested-by: @rustyrussell 

Signed-off-by: Vincenzo Palazzo <[email protected]>

# Title: 

Signed-off-by: Vincenzo Palazzo <[email protected]>
    @vincenzopalazzo
    vincenzopalazzo committed Jun 25, 2022
    Configuration menu
    Copy the full SHA
    bc4e6ae View commit details
    Browse the repository at this point in the history

  4. lightnind: removeDEFAULT_PORT global definition 

    Signed-off-by: Vincenzo Palazzo <[email protected]>
    @vincenzopalazzo
    vincenzopalazzo committed Jun 25, 2022
    Configuration menu
    Copy the full SHA
    465e32e View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2022

  1. test: introduce the default port function and remove hard coded port

    @vincenzopalazzo
    vincenzopalazzo committed Jun 26, 2022
    Configuration menu
    Copy the full SHA
    c84b416 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2022

  1. devtools: revert changes and make sure chainparams always set. 

    [Also fixes crash with -h, since chainparams was not set! --RR]
    @vincenzopalazzo @rustyrussell
    vincenzopalazzo authored and rustyrussell committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    90b6cbc View commit details
    Browse the repository at this point in the history