common: downgrade "internal error" errors from lnd. #5326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to 0.11.0 we had cases where we would treat errors as warnings: regretfully, this is still needed. This message in particular has been widely reported, and it now causes channel force closes. Downgrade and log. I did insert some snarky log message earlier, but hey, I'm sure CLN has done worse things to our peers! Signed-off-by: Rusty Russell <[email protected]> Changelog-Fixed: Protocol: treat LND "internal error" as warnings, not force close events (as we did in v0.10).
rustyrussell
force-pushed
the
internal-error-downgrade
branch
from
484a01b
to
ae30fb7
Compare
|
I'm running my node with this patch now. |
|
ACK ae30fb7 |
Thanks to @zerofeerouting for another report. "desc" here is the sanitized message, eg: "ERROR error channel 0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef: internal error" Signed-off-by: Rusty Russell <[email protected]>
vincenzopalazzo
approved these changes
Jun 23, 2022
There was a problem hiding this comment.
utACK effbd80
worried if you can write a lnprototest for this? if you can point out on how to find the lnd error message I can write a test on the flight I think? or I'm simplify the stuff to much?
@whitslack Please note original patch was ineffective! Second commit fixes properly. |
I don't think workarounds on (hopefully temporary!) implementation bugs should be included in lnprototest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to 0.11.0 we had cases where we would treat errors
as warnings: regretfully, this is still needed. This message
in particular has been widely reported, and it now causes
channel force closes.
Downgrade and log. I did insert some snarky log message earlier,
but hey, I'm sure CLN has done worse things to our peers!
Fixes: #5102
Changelog-None: Changelog is updated in v0.11.2 branch, which will be merged after that is released.