Gossmap api improvements #5596
Merged
Gossmap api improvements #5596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
force-pushed
the
gossmap-api-improve
branch
from
777fa1d
to
b86ed67
Compare
|
ACK b86ed67 |
Removes some warnings. Signed-off-by: Rusty Russell <[email protected]>
This allows GDB to print values, but also allows us to use them in 'case' statements. This wasn't allowed before because they're not constant terms. This also made it clear there's a clash between two error codes, so move one. Signed-off-by: Rusty Russell <[email protected]> Changelog-Changed: JSON-RPC: Error code from bcli plugin changed from 400 to 500.
Signed-off-by: Rusty Russell <[email protected]>
Useful if you want to store per-chan or per-node side-data in an array. Signed-off-by: Rusty Russell <[email protected]>
…rrect order. Signed-off-by: Rusty Russell <[email protected]>
They are surprisingly expensive! Running `time ./plugins/renepay/test/run-not_mcf-gossmap gossip_store-sgl.rustcorp.com.au-2022-04-19 024b9a1fa8e006f1e3937f65f66c408e6da8e1ca728ea43222a7381df1cc449605 02ebb3b8a2316b3e876ea3f3d8124a3ab97f30b128f619608eb06b5251235dc2d9 10000000000 0.1`: Before (-Og): real 0m1.495s Before (no opt): real 0m2.552s After (-Og): real 0m0.579s After (no opt): real 0m1.061s Signed-off-by: Rusty Russell <[email protected]>
|
Trivial rebase only. I don't understand why rust under CI is giving an internal compiler error; works fine here :( Ack 5a07785 |
rustyrussell
force-pushed
the
gossmap-api-improve
branch
from
b86ed67
to
5a07785
Compare
Nightly compilers are a bit unstable, we switched over to the stable branch now :-) |
|
Well, seems like |
Well, yeah! You need it, it's not included, and it require mako? Are you thinking of mrkd? Anyway, it's lnprototest python requirements in a knot: It's breaking everything RN. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were taken from my renepay branch, but are just surrounding work.