Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gossmap api improvements #5596

Merged
merged 6 commits into from
Sep 19, 2022
Merged

Gossmap api improvements #5596

merged 6 commits into from
Sep 19, 2022

Commits on Sep 18, 2022

  1. build: allow DEVELOPER builds with -Og and gcc 9.4.0 

    Removes some warnings.

Signed-off-by: Rusty Russell <[email protected]>
    @rustyrussell
    rustyrussell committed Sep 18, 2022
    Configuration menu
    Copy the full SHA
    cadd385 View commit details
    Browse the repository at this point in the history

  2. jsonrpc: make error codes an enum. 

    This allows GDB to print values, but also allows us to use them in
'case' statements.  This wasn't allowed before because they're not
constant terms.

This also made it clear there's a clash between two error codes,
so move one.

Signed-off-by: Rusty Russell <[email protected]>
Changelog-Changed: JSON-RPC: Error code from bcli plugin changed from 400 to 500.
    @rustyrussell
    rustyrussell committed Sep 18, 2022
    Configuration menu
    Copy the full SHA
    479b49d View commit details
    Browse the repository at this point in the history

  3. gossmap: fail to get capacity of locally-added chans (don't crash!). 

    Signed-off-by: Rusty Russell <[email protected]>
    @rustyrussell
    rustyrussell committed Sep 18, 2022
    Configuration menu
    Copy the full SHA
    b1701d7 View commit details
    Browse the repository at this point in the history

  4. gossmap: add functions to map index back to node/chan. 

    Useful if you want to store per-chan or per-node side-data in an array.

Signed-off-by: Rusty Russell <[email protected]>
    @rustyrussell
    rustyrussell committed Sep 18, 2022
    Configuration menu
    Copy the full SHA
    2c7c5ee View commit details
    Browse the repository at this point in the history

  5. gossmap: make local_addchan create private channel_announcement in co… 

    …rrect order.

Signed-off-by: Rusty Russell <[email protected]>
    @rustyrussell
    rustyrussell committed Sep 18, 2022
    Configuration menu
    Copy the full SHA
    3172dcd View commit details
    Browse the repository at this point in the history

  6. gossmap: optimize asserts(). 

    They are surprisingly expensive!

Running `time ./plugins/renepay/test/run-not_mcf-gossmap gossip_store-sgl.rustcorp.com.au-2022-04-19 024b9a1fa8e006f1e3937f65f66c408e6da8e1ca728ea43222a7381df1cc449605 02ebb3b8a2316b3e876ea3f3d8124a3ab97f30b128f619608eb06b5251235dc2d9 10000000000 0.1`:

Before (-Og):
	real	0m1.495s
Before (no opt):
	real	0m2.552s

After (-Og):
	real	0m0.579s
After (no opt):
	real	0m1.061s

Signed-off-by: Rusty Russell <[email protected]>
    @rustyrussell
    rustyrussell committed Sep 18, 2022
    Configuration menu
    Copy the full SHA
    5a07785 View commit details
    Browse the repository at this point in the history