Post v22.11 deprecation removals #5747
Conversation
Deprecated v0.11.0. Changelog-Removed: JSON-RPC: `pay` for a bolt11 which uses a `description_hash`, without setting `description` (deprecated v0.11.0). Signed-off-by: Rusty Russell <[email protected]>
Changelog-Removed: JSON-RPC: `invoice` `expiry` no longer allowed to be a string with suffix, use an integer number of seconds (deprecated v0.11.0)
Changelog-Removed: JSON-RPC: `fundpsbt`/`utxopsbt` `reserve` must be a number, not bool (deprecated v0.11.0) Signed-off-by: Rusty Russell <[email protected]>
Signed-off-by: Rusty Russell <[email protected]> Changelog-Removed: JSON-RPC: `close` `destination` no longer allows p2pkh or p2sh addresses (deprecated v0.11.0)
We ignored it anyway. Signed-off-by: Rusty Russell <[email protected]> Changelog-Removed: JSON-RPC: `sendpay` `route` argument `style` "legacy" (deprecated v0.11.0)
Replaced by `setchannel`. Signed-off-by: Rusty Russell <[email protected]> Changlog-Removed: JSON-RPC: `setchannelfee` (deprecated in v0.11.0)
rustyrussell
force-pushed
the
guilt/post-v22.11-deprecations
branch
from
18498a0
to
9cc0a32
Compare
|
Trivial rebase after markdown fix merge on master. Ack 9cc0a32 |
|
About 23.02, you did 2afe7a1 Sadly this is a gigantic pain in the ass in BTCPay side, as we are already checking the hash ourselves, and using a common abstraction of many node implementation to support them all. As a result, from 23.02 payment to lightning address or LNURL is broken. This one mean that we need to change our common interface to satisfy only c-lightning, where we need to pass the description on top of the bolt11. |
Nothing major, but this should be merged early so we can hear any complaints!